Allow implicit implementation of non-public interface members #54182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
added
Area-Compilers
Feature - Default Interface Impl
Youssef1313
reviewed
Jun 17, 2021
Comment on lines
+1011
to
+1017
| LanguageVersion? availableVersion = implementingType.DeclaringCompilation?.LanguageVersion; | ||
| if (requiredVersion > availableVersion) | ||
| { | ||
| diagnostics.Add(ErrorCode.ERR_ImplicitImplementationOfNonPublicInterfaceMember, GetInterfaceLocation(interfaceMember, implementingType), | ||
| implementingType, interfaceMember, implicitImpl, | ||
| availableVersion.GetValueOrDefault().ToDisplayString(), new CSharpRequiredLanguageVersion(requiredVersion)); | ||
| } |
There was a problem hiding this comment.
Wondering why this is not using the usual "CheckFeatureAvailability" method? #Resolved
There was a problem hiding this comment.
Wondering why this is not using the usual "CheckFeatureAvailability" method?
Because I am not interested in the generic error that helper would report.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dotnet/roslyn-compiler Please review |
3 similar comments
|
@dotnet/roslyn-compiler Please review |
|
@dotnet/roslyn-compiler Please review |
|
@dotnet/roslyn-compiler Please review |
RikkiGibson
approved these changes
Jun 22, 2021
|
@dotnet/roslyn-compiler For the second review. |
|
@dotnet/roslyn-compiler For the second review. |
3 similar comments
|
@dotnet/roslyn-compiler For the second review. |
|
@dotnet/roslyn-compiler For the second review. |
|
@dotnet/roslyn-compiler For the second review. |
|
@dotnet/roslyn-compiler For the second review. |
chsienki
approved these changes
Jun 25, 2021
ghost
added this to the
333fred
added a commit
that referenced
this pull request
Jun 25, 2021
…ures/caller-argument-expression * upstream/main: (492 commits) Add nullable ref annotations to SyntaxFactory (#54199) Add 'replace' APIs and hook them up to the IDE (#54270) Allow implicit implementation of non-public interface members (#54182) Make insertion a stage of the official build (#54376) Cleanup Remove unused property Simplify glyph computation Report all-empty top level statements. (#54385) Calculate TypeParameterKind based on the container type (#54200) vert not roaming Split tests Multple matches Report as we get results Fixup tests Update tests Avoid thread dependency in VirtualMemoryNotificationListener constructor Fast progression search. Add LanguageVersion 10 (#54359) Sure, why not ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53566.
Fixes #53565.