Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to features/caller-argument-expression #52405

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
203 commits
Select commit Hold shift + click to select a range
b90760f
Pass CancellationToken to SelectAsArrayAsync
sharwell Mar 23, 2021
3cdcb84
Export option persisters via IOptionPersisterProvider
sharwell Mar 23, 2021
b6c096a
Avoid loading packages synchronously
sharwell Mar 23, 2021
fcc29a2
Avoid loading assemblies on the UI thread
sharwell Mar 23, 2021
b92dc39
Ensure GlobalOptionService always has persister instances
sharwell Mar 24, 2021
b7a924e
Update documentation
sharwell Mar 25, 2021
32b901b
Null-annotate RoamingVisualStudioProfileOptionPersister
sharwell Mar 25, 2021
f917e5f
Remove the default value for TodoCommentOptions.TokenList
sharwell Mar 25, 2021
b659480
Add fast path for empty TODO tokens
sharwell Mar 25, 2021
05ae9e8
Simplify interpolation
sharwell Mar 25, 2021
5ac103e
Temp work
CyrusNajmabadi Mar 27, 2021
87bfc80
Delete AssertEx.Throws
jasonmalinowski Mar 27, 2021
da10d5f
Process source generated docs after other docs
CyrusNajmabadi Mar 27, 2021
504954e
doc
CyrusNajmabadi Mar 27, 2021
66ed602
cleanup
CyrusNajmabadi Mar 27, 2021
addf5d4
revert
CyrusNajmabadi Mar 27, 2021
045c50c
revert
CyrusNajmabadi Mar 27, 2021
352eb04
Extract method
CyrusNajmabadi Mar 27, 2021
a0cb671
use set equality
CyrusNajmabadi Mar 27, 2021
fa8bb76
Fix conversion completion with a following variable declaration.
CyrusNajmabadi Mar 27, 2021
c4bee72
Remove obsolete test helpers (#52195)
cston Mar 28, 2021
faf7c13
Add UI for editorconfig files
jmarolf Jan 6, 2021
bab8e5d
update settings helper values for IOption2 writer
jmarolf Mar 19, 2021
0cc4b9e
Update .gitignore
jmarolf Mar 18, 2021
c4ff7f3
Update src/EditorFeatures/Core/EditorConfigSettings/Extensions/Soluti…
jmarolf Mar 19, 2021
c1ec753
use WhereNotNull
jmarolf Mar 19, 2021
837c00f
simplify null checking of array
jmarolf Mar 19, 2021
b619aef
fix tab backgound color in some themes
jmarolf Mar 19, 2021
a13246a
rename CreateGridElemetn to CreateItemElement
jmarolf Mar 19, 2021
ec7740f
use common guid
jmarolf Mar 19, 2021
ed97136
remove incorrect comment
jmarolf Mar 22, 2021
759e0af
split types to separate files
jmarolf Mar 22, 2021
0e84436
xaml it up
jmarolf Mar 22, 2021
0d96fc1
set automation properties
jmarolf Mar 22, 2021
56d6ec2
tweaks to filerability
jmarolf Mar 24, 2021
22a61db
do not respond to workspace changed events instead let a new window b…
jmarolf Mar 24, 2021
289aa3c
do not allow the user to sort or filter mutable data
jmarolf Mar 24, 2021
b7c06a3
add data tests
jmarolf Mar 24, 2021
f8f2106
xaml fixes found in testing
jmarolf Mar 25, 2021
2976da0
remove async from data providers
jmarolf Mar 27, 2021
7e21933
simplify view
jmarolf Mar 28, 2021
e3df1f6
fix text header
jmarolf Mar 28, 2021
c8472e1
ensure that AnalyzerConfigOptionsResult is consulted
jmarolf Mar 28, 2021
0f65913
handle null case in tests
jmarolf Mar 29, 2021
e2dc27f
Added Razor.LanguageServer to Razor ExternalAccess Visibility
TanayParikh Mar 29, 2021
d1af11b
simplify threading for updating code
jmarolf Mar 29, 2021
b21007b
simplfy updating threading model for editorconfig buffer
jmarolf Mar 29, 2021
65132ce
Merge pull request #52213 from dotnet/TanayParikh-patch-1
Mar 29, 2021
f52afd9
Merge pull request #51069 from jmarolf/feature/settings-ui
Mar 29, 2021
27053c3
Avoid boxing enum types on .NET Framework
sharwell Mar 29, 2021
c3013b8
Merge remote-tracking branch 'dotnet/main' into persister-provider
sharwell Mar 29, 2021
892422b
Work
CyrusNajmabadi Mar 29, 2021
21234cf
Update language feature status: parameterless struct constructors and…
cston Mar 29, 2021
3ac315a
Add tests
CyrusNajmabadi Mar 29, 2021
05d9b92
Update LanguageServer.Protocol dependency to 16.10.161.
NTaylorMullen Mar 29, 2021
9cff09c
Clarify some of the language around determinism (#52113)
jaredpar Mar 29, 2021
b5de771
Feedbqack
CyrusNajmabadi Mar 29, 2021
ab3eff4
Reorder
CyrusNajmabadi Mar 29, 2021
7b9df38
Merge pull request #52063 from sharwell/persister-provider
sharwell Mar 29, 2021
6ea7d6a
Add manual package set to publishing which doesn't use arcade
JoeRobich Mar 29, 2021
270546b
Merge pull request #52231 from JoeRobich/add-manual-publishing
JoeRobich Mar 29, 2021
e74ddf9
Don't get generated sources during solution load
CyrusNajmabadi Mar 29, 2021
b9034c4
Merge pull request #52183 from jasonmalinowski/remove-assertex.throws
jasonmalinowski Mar 29, 2021
ee7d111
Update Versions.props
allisonchou Mar 29, 2021
99259c7
Merge pull request #52193 from CyrusNajmabadi/conversionCompletoinVar
CyrusNajmabadi Mar 29, 2021
fb2d906
Authenticate for dnceng/dotnet-tools nuget feed
JoeRobich Mar 30, 2021
d60fa09
Merge branch 'release/dev16.10' into main
JoeRobich Mar 30, 2021
d10df88
Fix caret affinity in GetReferencedSymbolsToLeftOfCaretAsync
sharwell Mar 30, 2021
e6b01ea
Set argument completion option to default for tests
sharwell Mar 30, 2021
5536089
Extract helper method TryInsertArgumentCompletionSnippet
sharwell Mar 30, 2021
5da7e00
Prefer argument completion snippets to named snippets
sharwell Mar 30, 2021
52acdfd
Fix argument completion for constructors
sharwell Mar 30, 2021
6bc3af6
Merge pull request #52235 from dotnet/16.10.2-snap
allisonchou Mar 30, 2021
b586d04
Add setting to turn off annoying semi-colon behaviour (#52214)
davidwengier Mar 30, 2021
4adc70f
Update documentation for FatalError handlers
sharwell Mar 30, 2021
d0ec33d
Revert add manual package publishing
JoeRobich Mar 30, 2021
3c20d97
Merge commit 'd0ec33d3f113c90c5656774162537fab7a6179cf' into main
JoeRobich Mar 30, 2021
ef0c53b
Add 'Static Abstract Members In Interfaces' to 'Language Feature Stat…
AlekseyTs Mar 30, 2021
5f2bae2
Combine summary and remarks for readability
sharwell Mar 30, 2021
ff84ce0
Clarify documentation in FatalError
sharwell Mar 30, 2021
96aff52
Merge pull request #52218 from sharwell/avoid-boxing-2
sharwell Mar 30, 2021
9da4af0
Clean up for clarity
sharwell Mar 30, 2021
649054b
Fix Type annotations on BoundExpression overrides (#52203)
cston Mar 30, 2021
7338cb4
Update Microsoft.CodeAnalysis.ExternalAccess.Razor.csproj
TanayParikh Mar 30, 2021
fc165b3
Suppress documentation warnings for net20
sharwell Mar 30, 2021
78a28a8
Clear cached MefHostService between MSBuild tests
JoeRobich Mar 30, 2021
d0e6466
Use CommonCompiler in Rebuild tests (#52208)
jaredpar Mar 30, 2021
dcb3719
Merge pull request #52245 from sharwell/snippet-before-semicolon
sharwell Mar 30, 2021
e6bcc9b
Use a TestAccessor to clear cached services
JoeRobich Mar 31, 2021
3ebfc17
Merge pull request #52266 from dotnet/TanayParikh-patch-1
Mar 31, 2021
92b6499
Pass CancellationToken in compilers layer
jmarolf Mar 31, 2021
97846f9
Pass CancellationToken at the Analyzers layer
jmarolf Mar 31, 2021
3113407
Pass CancellationTokens in the EditorFeature layer
jmarolf Mar 31, 2021
8762109
Pass CancellationToken at Features layer
jmarolf Mar 31, 2021
a04a909
Pass CancellationTokens in the Interactive layer
jmarolf Mar 31, 2021
35bbbc1
Pass CancellationTokens in the Visual Studio layer
jmarolf Mar 31, 2021
3a64531
Pass CancellationToken in the Workspace layer
jmarolf Mar 31, 2021
f2452e0
enforce passing CancellationTokens were present
jmarolf Mar 31, 2021
57bfe11
Merge pull request #52268 from dotnet/merges/release/dev16.10-to-main
allisonchou Mar 31, 2021
f7dbc42
Merge pull request #52267 from JoeRobich/clear-cached-mefhostservices
JoeRobich Mar 31, 2021
0be2539
Don't report extra unnecessary diagnostics for static ctors (#52049)
Youssef1313 Mar 31, 2021
2f607bd
Normalize pointers to have asterisk next to type instead of identifie…
Youssef1313 Mar 31, 2021
cf734b6
Avoid Gen 0 GC of cached source generator result
sharwell Mar 31, 2021
823e529
Use documented LOH threshold constant
sharwell Mar 31, 2021
323ad9c
Merge pull request #52281 from jmarolf/always-pass-cancellation-token…
jmarolf Mar 31, 2021
35ba6a0
suppress warning with comment
jmarolf Mar 31, 2021
e93e420
Merge pull request #52253 from sharwell/document-error-handling
sharwell Mar 31, 2021
109a835
Extend Rebuild test support (#52274)
jaredpar Mar 31, 2021
f0f7d6a
pass CancellationToken to a few more cases
jmarolf Mar 31, 2021
6e54932
Move IDE0066 'ContainsDirectives' check from analyzer to code fix
sharwell Mar 31, 2021
1b66fe3
Simplify navigate to code.
CyrusNajmabadi Mar 31, 2021
7278fd1
Fix namespace in Rebuild library (#52254)
RikkiGibson Mar 31, 2021
06f1a31
Merge pull request #52298 from sharwell/sg-caching
sharwell Mar 31, 2021
073268b
Simplify and fix baseline reader disposal (#52244)
tmat Mar 31, 2021
f6cdfab
Merge pull request #52185 from CyrusNajmabadi/navToLazy
CyrusNajmabadi Mar 31, 2021
c2f68b9
Enable test for fixed Smart Break Line issue
sharwell Mar 31, 2021
7a07596
Merge branch 'main' into simplifyNavTo
CyrusNajmabadi Mar 31, 2021
2232e90
Merge pull request #52276 from jmarolf/always-pass-cancellation-token…
jmarolf Mar 31, 2021
e233c62
Move to a single simple type for internal NavTo results
CyrusNajmabadi Mar 31, 2021
6f3e25e
Merge branch 'simplifyNavTo' into simpleNavToSerialization
CyrusNajmabadi Mar 31, 2021
3ff77fb
Merge pull request #52279 from jmarolf/always-pass-cancellation-token…
jmarolf Mar 31, 2021
f5c6199
Merge remote-tracking branch 'upstream/main' into simpleNavToSerializ…
CyrusNajmabadi Mar 31, 2021
3416d39
Merge remote-tracking branch 'upstream/main' into simplifyNavTo
CyrusNajmabadi Mar 31, 2021
e1fc966
Enable Remove Unused References by default
JoeRobich Mar 31, 2021
e84bb23
EnC: Don't consider changing unsafe modifier as rude edit (#52164)
Youssef1313 Mar 31, 2021
1f9e3d4
Fix
CyrusNajmabadi Mar 31, 2021
450d6ee
Merge branch 'simplifyNavTo' into simpleNavToSerialization
CyrusNajmabadi Mar 31, 2021
dc69ed6
Merge pull request #52309 from sharwell/enable-test
sharwell Mar 31, 2021
0f1c081
Simplify more
CyrusNajmabadi Mar 31, 2021
7734b93
Simplify more
CyrusNajmabadi Mar 31, 2021
b8c706b
Merge remote-tracking branch 'upstream/main' into simpleNavToSerializ…
CyrusNajmabadi Mar 31, 2021
ccb5f6e
Merge pull request #52317 from dotnet/dev/jorobich/enable-by-default
JoeRobich Mar 31, 2021
bb60640
NRT
CyrusNajmabadi Mar 31, 2021
9313266
Simplify
CyrusNajmabadi Mar 31, 2021
2adc0bd
Merge pull request #52304 from CyrusNajmabadi/simplifyNavTo
CyrusNajmabadi Apr 1, 2021
cc3308e
Merge remote-tracking branch 'upstream/main' into simpleNavToSerializ…
CyrusNajmabadi Apr 1, 2021
0076c29
PRfeedback
CyrusNajmabadi Apr 1, 2021
70fb13f
Merge pull request #52303 from sharwell/warn-with-pragma
sharwell Apr 1, 2021
9e0adbe
Merge remote-tracking branch 'upstream/main' into simpleNavToSerializ…
CyrusNajmabadi Apr 1, 2021
481e4b8
Build
CyrusNajmabadi Apr 1, 2021
e94f66d
Merge pull request #52323 from dotnet/merges/release/dev16.10-to-main
allisonchou Apr 1, 2021
fbaf455
Avoid realizing syntax node from a tree that doesn't own the context.…
AlekseyTs Apr 1, 2021
31570ce
Fix global option service to handle non-default values from persisters
mavasani Apr 1, 2021
d90b443
Replace iff with "if and only if" (#52294)
BillWagner Apr 1, 2021
f3a4878
Merge pull request #52335 from mavasani/FixTodoCommentsIssue
mavasani Apr 1, 2021
86a42b7
Make order of extension loading deterministic (#52086)
chsienki Apr 1, 2021
e74866f
Merge pull request #52280 from jmarolf/always-pass-cancellation-token…
jmarolf Apr 1, 2021
bea0133
Merge pull request #52278 from jmarolf/always-pass-cancellation-token…
jmarolf Apr 1, 2021
9be38c3
add comment explaining that cancelation is never allowed
jmarolf Apr 1, 2021
9756547
Merge pull request #52277 from jmarolf/always-pass-cancellation-token…
jmarolf Apr 1, 2021
fdbd7fa
Offer href as completion attribute for <see/> doc comments
Youssef1313 Apr 1, 2021
4fb7f43
Ensure that priority docs only refer to the project being searched
CyrusNajmabadi Apr 1, 2021
f5bd51a
Merge pull request #52144 from sharwell/comment-tokens
sharwell Apr 1, 2021
d88a7de
Offer href in <seealso/>
Youssef1313 Apr 1, 2021
2d01976
Add test: SeeAlsoAttributeNames
Youssef1313 Apr 1, 2021
c96203b
Thread things along
CyrusNajmabadi Apr 1, 2021
c45e435
Extract out common core.
CyrusNajmabadi Apr 1, 2021
74b4385
move project resolution back to host side.
CyrusNajmabadi Apr 1, 2021
f1698cf
Merge branch 'simpleNavToSerialization' into navToOnLoad
CyrusNajmabadi Apr 1, 2021
b1fc87f
Merge pull request #52344 from dotnet/merges/release/dev16.10-to-main
allisonchou Apr 1, 2021
65298a8
Add code to search from index
CyrusNajmabadi Apr 1, 2021
23cb368
Merge pull request #52275 from jmarolf/always-pass-cancellation-token…
jmarolf Apr 1, 2021
459edc9
working
CyrusNajmabadi Apr 1, 2021
9faa67f
Be resilient to stale items that are out of bounds.
CyrusNajmabadi Apr 1, 2021
8a8e7aa
Merge remote-tracking branch 'upstream/main' into simpleNavToSerializ…
CyrusNajmabadi Apr 1, 2021
7b17ab7
Merge branch 'simpleNavToSerialization' into navToOnLoad
CyrusNajmabadi Apr 1, 2021
41f9576
Merge branch 'main' of https://github.com/dotnet/roslyn into enforce-…
jmarolf Apr 1, 2021
173514b
forward CancellationTokens that were missed/changed
jmarolf Apr 1, 2021
53e539d
Fix Quick Info integration tests
sharwell Apr 1, 2021
cea4710
Remove unnecessary test delays
sharwell Apr 1, 2021
e545fb4
Restore original OptionSet constructor
sharwell Apr 2, 2021
710b5c3
Merge pull request #52342 from Youssef1313/href-completion
sharwell Apr 2, 2021
db4b3ea
Mark import completion items as complex (#52332)
333fred Apr 2, 2021
f48d930
Handle function pointer and xml normalization (#51981)
Youssef1313 Apr 2, 2021
b969565
Merge pull request #52315 from CyrusNajmabadi/simpleNavToSerialization
CyrusNajmabadi Apr 2, 2021
254969c
Merge remote-tracking branch 'upstream/main' into navToOnLoad
CyrusNajmabadi Apr 2, 2021
5cfdb10
Pass along flag.
CyrusNajmabadi Apr 2, 2021
0f32f6b
Pass along flag.
CyrusNajmabadi Apr 2, 2021
ddb9f1c
Add comment
CyrusNajmabadi Apr 2, 2021
a97fa89
Fix namespaces
Youssef1313 Apr 2, 2021
409ef57
Handle typeof expression in complete statement
Youssef1313 Apr 2, 2021
f89b038
Handle tuple expression in complete statement
Youssef1313 Apr 2, 2021
934aedf
Merge pull request #52359 from sharwell/fix-signature
sharwell Apr 2, 2021
5258565
Merge pull request #52355 from sharwell/simplify-test
sharwell Apr 2, 2021
7a567d1
Merge pull request #52354 from sharwell/quickinfo-test
sharwell Apr 2, 2021
6546dbc
Merge pull request #52282 from jmarolf/enforce-passing-cancellation-t…
jmarolf Apr 2, 2021
6fba65a
DOcs
CyrusNajmabadi Apr 2, 2021
d8dd359
Merge pull request #52370 from dotnet/merges/release/dev16.10-to-main
allisonchou Apr 2, 2021
8c22ff5
remove unused value
CyrusNajmabadi Apr 2, 2021
d0b25e6
docs
CyrusNajmabadi Apr 2, 2021
affd18b
NRT enable
CyrusNajmabadi Apr 2, 2021
b555e8c
Renames
CyrusNajmabadi Apr 2, 2021
d23017b
NRTwork
CyrusNajmabadi Apr 2, 2021
4e88fe2
Missing cancellation token
CyrusNajmabadi Apr 2, 2021
53d999c
Merge pull request #52364 from Youssef1313/complete-statement-typeof
sharwell Apr 2, 2021
bb6a827
Merge pull request #52363 from Youssef1313/cleanup
CyrusNajmabadi Apr 2, 2021
ebcd714
Merge pull request #52351 from CyrusNajmabadi/navToOnLoad
CyrusNajmabadi Apr 3, 2021
1f7e929
Import System namespace when adding null check
Youssef1313 Apr 3, 2021
072ff07
Fix VB tests
Youssef1313 Apr 3, 2021
6fdccd1
Fix tuple naming
Youssef1313 Apr 3, 2021
6ab85a2
Update ParenthesisBraceCompletionService.cs
Youssef1313 Apr 3, 2021
3a30d52
Merge pull request #52392 from Youssef1313/add-imports-null-check-cod…
CyrusNajmabadi Apr 3, 2021
d056cbe
Merge pull request #52395 from Youssef1313/patch-21
CyrusNajmabadi Apr 3, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Compilers.sln
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CodeStyleConfigFileGenerato
EndProject
Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.Collections", "src\Dependencies\Collections\Microsoft.CodeAnalysis.Collections.shproj", "{E919DD77-34F8-4F57-8058-4D3FF4C2B241}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Rebuild", "src\Compilers\Core\Rebuild\Rebuild.csproj", "{321F9FED-AACC-42CB-93E5-541D79E099E8}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild", "src\Compilers\Core\Rebuild\Microsoft.CodeAnalysis.Rebuild.csproj", "{321F9FED-AACC-42CB-93E5-541D79E099E8}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild.UnitTests", "src\Compilers\Core\RebuildTest\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj", "{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}"
EndProject
Expand Down
2 changes: 1 addition & 1 deletion Compilers.slnf
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"src\\Compilers\\Core\\MSBuildTask\\Microsoft.Build.Tasks.CodeAnalysis.csproj",
"src\\Compilers\\Core\\Portable\\Microsoft.CodeAnalysis.csproj",
"src\\Compilers\\Core\\RebuildTest\\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj",
"src\\Compilers\\Core\\Rebuild\\Rebuild.csproj",
"src\\Compilers\\Core\\Rebuild\\Microsoft.CodeAnalysis.Rebuild.csproj",
"src\\Compilers\\Extension\\Roslyn.Compilers.Extension.csproj",
"src\\Compilers\\Server\\VBCSCompilerTests\\VBCSCompiler.UnitTests.csproj",
"src\\Compilers\\Server\\VBCSCompiler\\VBCSCompiler.csproj",
Expand Down
2 changes: 1 addition & 1 deletion Roslyn.sln
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.Coll
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Collections.Package", "src\Dependencies\Collections\Microsoft.CodeAnalysis.Collections.Package.csproj", "{0C2E1633-1462-4712-88F4-A0C945BAD3A8}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Rebuild", "src\Compilers\Core\Rebuild\Rebuild.csproj", "{B7D29559-4360-434A-B9B9-2C0612287999}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild", "src\Compilers\Core\Rebuild\Microsoft.CodeAnalysis.Rebuild.csproj", "{B7D29559-4360-434A-B9B9-2C0612287999}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild.UnitTests", "src\Compilers\Core\RebuildTest\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj", "{21B49277-E55A-45EF-8818-744BCD6CB732}"
EndProject
Expand Down
26 changes: 13 additions & 13 deletions azure-pipelines-official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,19 @@ stages:
- job: OfficialBuild
displayName: Official Build
timeoutInMinutes: 360
# Conditionally set build pool so we can share this YAML when building with different pipeline (devdiv vs dnceng)
pool:
# Conditionally set build pool so we can share this YAML when building with different pipeline (devdiv vs dnceng)
pool:
${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
name: VSEngSS-MicroBuild2017
demands:
demands:
- msbuild
- visualstudio
- DotNetFramework
${{ if eq(variables['System.TeamProject'], 'internal') }}:
name: NetCoreInternal-Pool
queue: BuildPool.Windows.10.Amd64.VS2019.Pre

steps:
steps:
# Make sure our two pipelines generate builds with distinct build numbers to avoid confliction.
# i.e. DevDiv builds will have even rev# whereas dnceng builds will be odd.
- task: PowerShell@2
Expand All @@ -82,7 +82,7 @@ stages:
type: 'Build'
tags: 'OfficialBuild'
condition: and(succeeded(), endsWith(variables['SourceBranchName'], '-vs-deps'), eq(variables['PRNumber'], 'default'))

- task: tagBuildOrRelease@0
displayName: Tag PR validation build
inputs:
Expand Down Expand Up @@ -152,13 +152,13 @@ stages:
displayName: Build
inputs:
filePath: eng/build.ps1
arguments: -ci
arguments: -ci
-restore
-build
-pack
-sign
-publish
-binaryLog
-binaryLog
-configuration $(BuildConfiguration)
-officialBuildId $(Build.BuildNumber)
-officialSkipTests $(SkipTests)
Expand Down Expand Up @@ -249,7 +249,7 @@ stages:

# Publish insertion packages to CoreXT store.
- task: NuGetCommand@2
displayName: Publish CoreXT Packages
displayName: Publish CoreXT Packages
inputs:
command: push
packagesToPush: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)\DevDivPackages\**\*.nupkg'
Expand All @@ -270,7 +270,7 @@ stages:
ArtifactName: 'VSSetup'
condition: succeeded()

# Publish our NuPkgs as an artifact. The name of this artifact must be PackageArtifacts as the
# Publish our NuPkgs as an artifact. The name of this artifact must be PackageArtifacts as the
# arcade templates depend on the name.
- task: PublishBuildArtifacts@1
displayName: Publish Artifact Packages
Expand All @@ -295,7 +295,7 @@ stages:
- template: /eng/common/templates/job/publish-build-assets.yml
parameters:
publishUsingPipelines: true
dependsOn:
dependsOn:
- OfficialBuild
${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
queue:
Expand All @@ -304,7 +304,7 @@ stages:
pool:
vmImage: vs2017-win2016

# We need to skip post-build stages for PR validation build, but it can only be identified by
# We need to skip post-build stages for PR validation build, but it can only be identified by
# the runtime variable 'PRNumber', thus this dummy stage. Also the dummy job is required
# otherwise AzDO would just repeat jobs from previous stage.
- stage: SetValidateDependency
Expand All @@ -324,8 +324,8 @@ stages:
# https://github.com/dotnet/arcade/issues/2871 is resolved.
enableSymbolValidation: false
enableSourceLinkValidation: false
# It's important that post-build stages are depends on 'SetValidateDependency' stage instead of 'build',
# since we don't want to publish validation build.
# It's important that post-build stages are depends on 'SetValidateDependency' stage instead of 'build',
# since we don't want to publish validation build.
validateDependsOn:
- SetValidateDependency
dependsOn:
Expand Down
4 changes: 3 additions & 1 deletion docs/Language Feature Status.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ efforts behind them.
| ------- | ------ | ----- | ---------- | -------- | --------- |
| [Record structs](https://github.com/dotnet/csharplang/issues/4334) | [record-structs](https://github.com/dotnet/roslyn/tree/features/record-structs) | [In Progress](https://github.com/dotnet/roslyn/issues/51199) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [RikkiGibson](https://github.com/RikkiGibson) | [jcouv](https://github.com/jcouv) |
| [Global Using Directive](https://github.com/dotnet/csharplang/issues/3428) | [GlobalUsingDirective](https://github.com/dotnet/roslyn/tree/features/GlobalUsingDirective) | [In Progress](https://github.com/dotnet/roslyn/issues/51307) | [AlekseyTs](https://github.com/AlekseyTs) | [333fred](https://github.com/333fred), [cston](https://github.com/cston) | [AlekseyTs](https://github.com/AlekseyTs) |
| [Static Abstract Members In Interfaces](https://github.com/dotnet/csharplang/issues/4436) | [StaticAbstractMembersInInterfaces](https://github.com/dotnet/roslyn/tree/features/StaticAbstractMembersInInterfaces) | [In Progress](https://github.com/dotnet/roslyn/issues/52221) | [AlekseyTs](https://github.com/AlekseyTs) | [333fred](https://github.com/333fred), [RikkiGibson](https://github.com/RikkiGibson) | [MadsTorgersen](https://github.com/MadsTorgersen) |
| [File-scoped namespace](https://github.com/dotnet/csharplang/issues/137) | [FileScopedNamespaces](https://github.com/dotnet/roslyn/tree/features/FileScopedNamespaces) | In Progress | [chsienki](https://github.com/chsienki) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [Interpolated string improvements](https://github.com/dotnet/csharplang/issues/4487) | [interpolated-string](https://github.com/dotnet/roslyn/tree/features/interpolated-string) | [In Progress](https://github.com/dotnet/roslyn/issues/51499) | [333fred](https://github.com/333fred) | [AlekseyTs](https://github.com/AlekseyTs), [chsienki](https://github.com/chsienki) | [jaredpar](https://github.com/jaredpar) |
| [Parameterless struct constructors](https://github.com/dotnet/csharplang/issues/99) | TBD | In Progress | [cston](https://github.com/cston) | [jcouv](https://github.com/jcouv), [333fred](https://github.com/333fred) | [jcouv](https://github.com/jouv) |
| [Parameterless struct constructors](https://github.com/dotnet/csharplang/issues/99) | [struct-ctors](https://github.com/dotnet/roslyn/tree/features/struct-ctors) | [In Progress](https://github.com/dotnet/roslyn/issues/51698) | [cston](https://github.com/cston) | [jcouv](https://github.com/jcouv), [333fred](https://github.com/333fred) | [jcouv](https://github.com/jouv) |
| [Lambda improvements](https://github.com/dotnet/csharplang/blob/main/proposals/lambda-improvements.md) | [lambdas](https://github.com/dotnet/roslyn/tree/features/lambdas) | [In Progress](https://github.com/dotnet/roslyn/issues/52192) | [cston](https://github.com/cston) | [333fred](https://github.com/333fred), [jcouv](https://github.com/jcouv) | [jaredpar](https://github.com/jaredpar) |
| [nameof(parameter)](https://github.com/dotnet/csharplang/issues/373) | main | [In Progress](https://github.com/dotnet/roslyn/issues/40524) | [jcouv](https://github.com/jcouv) | TBD | [jcouv](https://github.com/jcouv) |
| [Improved Definite Assignment](https://github.com/dotnet/csharplang/issues/4465) | [improved-definite-assignment](https://github.com/dotnet/roslyn/tree/features/improved-definite-assignment) | [In Progress](https://github.com/dotnet/roslyn/issues/51463) | [RikkiGibson](https://github.com/RikkiGibson) | [jcouv](https://github.com/jcouv) | [jaredpar](https://github.com/jaredpar) |
| [Relax ordering of `ref` and `partial` modifiers](https://github.com/dotnet/csharplang/issues/946) | [ref-partial](https://github.com/dotnet/roslyn/tree/features/ref-partial) | In Progress | [alrz](https://github.com/alrz) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
Expand Down
15 changes: 8 additions & 7 deletions docs/compilers/Deterministic Inputs.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
Deterministic Inputs
====================

We are aiming to make the compilers ultimately deterministic (https://github.com/dotnet/roslyn/issues/372). What that means is that the "same inputs" will cause the compilers to produce the "same outputs".
The C# and VB compilers are fully deterministic when the `/deterministic` option is specified (this is the default in the .NET SDK). This means that the "same inputs" will cause the compilers to produce the "same outputs" byte for byte.

The following are considered inputs to the compiler for the purpose of determinism:

- The sequence of command-line parameters
- The contents of the compiler's `.rsp` response file.
- The precise version of the compiler used, and its referenced assemblies
- The sequence of command-line parameters (order is important)
- The precise version of the compiler used and the files included in its deployment: reference assemblies, rsp, etc ...
- Current full directory path (you can reduce this to a relative path; see https://github.com/dotnet/roslyn/issues/949)
- (Binary) contents of all files explicitly passed to the compiler, directly or indirectly, including
- source files
Expand All @@ -17,15 +16,17 @@ The following are considered inputs to the compiler for the purpose of determini
- the strong name key file
- `@` response files
- Analyzers
- Generators
- Rulesets
- "additional files" that may be used by analyzers
- The current culture (for the language in which diagnostics and exception messages are produced).
- "additional files" that may be used by analyzers and generators
- The current culture if `/preferreduilang` is not specified (for the language in which diagnostics and exception messages are produced).
- The current OS code page if `/codepage` is not specified and any of the input source files do not have BOM and are not UTF-8 encoded.
- The existence, non-existence, and contents of files on the compiler's search paths (specified, e.g. by `/lib` or `/recurse`)
- The CLR platform on which the compiler is run:
- The result of `double` arithmetic performed for constant-folding may use excess precision on some platforms.
- The compiler uses Unicode tables provided by the platform.
- The version of the zlib library that the CLR uses to implement compression (when `/embed` or `/debug:embedded` is used).
- The value of `%LIBPATH%`, as it can affect analyzer dependency loading.
- The value of `%LIBPATH%`, as it can affect reference discovery if not fully qualified and how the runtime handles analyzer / generator dependency loading.
- The full path of source files although `/pathmap` can be used to normalize this between compiles of the same code in different root directories.

At the moment the compiler also depends on the time of day and random numbers for GUIDs, so it is not deterministic unless you specify `/deterministic`.
2 changes: 1 addition & 1 deletion docs/wiki/Manual-Testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ When doing a test pass, copy this page and consider using these status indicator
| **Typing** | :fast_forward: **General Typing**<br />- Type and paste new constructs<br />- Nothing interferes with verbatim typing | | | |
| | :mag: :fast_forward: **Completion**<br />- Typing new keyword/construct names<br />- Dotting off of new constructs<br />- Matching part of the identifier is highlighted (including word prefix matches) [Visual Studio 2015 Update 1]<br />- Target type preselection [Visual Studio 2017]<br />IntelliSense filtering [Visual Studio 2017] | | | |
| | :fast_forward: **Formatting** <br />- Spacing in and around new constructs<br />- Spacing options<br />- Format Document command<br /> `Tools > Options` settings should be respected | | | |
| | :fast_forward: **Automatic Brace Completion** (*C# only*) <br />- Auto-insert close brace<br />- Shift+Enter commit of IntelliSense and any pending brace completion sessions (Known issue: https://github.com/dotnet/roslyn/issues/18065) | | | N/A |
| | :fast_forward: **Automatic Brace Completion** (*C# only*) <br />- Auto-insert close brace<br />- Shift+Enter commit of IntelliSense and any pending brace completion sessions (Currently C# only: https://github.com/dotnet/roslyn/issues/18065) | | | N/A |
| | :fast_forward: **Indentation** <br />- Typing `Enter` in an unfinished statement indents the next line | | | |
| **Navigating** | :mag: :fast_forward: **Go To Definition** <br />- F12 from callsites to definition<br />- Ctrl+click [Visual Studio 2017 version 15.4] | | | |
| | :fast_forward: **Go To Implementation** <br />- Ctrl+F12 to jump from virtual members to their implementations<br />- Jump from inheritable types to their implementations | | | N/A |
Expand Down
5 changes: 3 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<MajorVersion>3</MajorVersion>
<MinorVersion>10</MinorVersion>
<PatchVersion>0</PatchVersion>
<PreReleaseVersionLabel>2</PreReleaseVersionLabel>
<PreReleaseVersionLabel>3</PreReleaseVersionLabel>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<!--
By default the assembly version in official builds is "$(MajorVersion).$(MinorVersion).0.0".
Expand All @@ -34,7 +34,7 @@
<VisualStudioEditorPackagesVersion>16.9.220</VisualStudioEditorPackagesVersion>
<ILAsmPackageVersion>5.0.0-alpha1.19409.1</ILAsmPackageVersion>
<ILDAsmPackageVersion>5.0.0-preview.1.20112.8</ILDAsmPackageVersion>
<MicrosoftVisualStudioLanguageServerProtocolPackagesVersion>16.10.139</MicrosoftVisualStudioLanguageServerProtocolPackagesVersion>
<MicrosoftVisualStudioLanguageServerProtocolPackagesVersion>16.10.161</MicrosoftVisualStudioLanguageServerProtocolPackagesVersion>
<MicrosoftVisualStudioShellPackagesVersion>16.9.30921.310</MicrosoftVisualStudioShellPackagesVersion>
<MicrosoftBuildPackagesVersion>16.5.0</MicrosoftBuildPackagesVersion>
<!-- The version of Roslyn we build Source Generators against that are built in this
Expand All @@ -49,6 +49,7 @@
<PropertyGroup>
<BasicUndoVersion>0.9.3</BasicUndoVersion>
<BenchmarkDotNetVersion>0.12.1</BenchmarkDotNetVersion>
<BenchmarkDotNetDiagnosticsWindowsVersion>0.12.1</BenchmarkDotNetDiagnosticsWindowsVersion>
<DiffPlexVersion>1.4.4</DiffPlexVersion>
<EnvDTEVersion>$(MicrosoftVisualStudioShellPackagesVersion)</EnvDTEVersion>
<EnvDTE80Version>$(MicrosoftVisualStudioShellPackagesVersion)</EnvDTE80Version>
Expand Down
Loading