Include source generators in TryGetMethodDescriptorAsync #51686
Conversation
| @@ -246,7 +246,7 @@ private static async Task<ReferenceMethodDescriptor> TryGetMethodDescriptorAsync | |||
| return null; | |||
| } | |||
|
|
|||
| var document = solution.GetDocument(doc.Id); | |||
| var document = await solution.GetDocumentAsync(doc.Id, includeSourceGenerated: true, cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
i honestly don't understand the point of the before/after line in teh first place. Right above this, we already found teh 'doc', so why not just use that?
There was a problem hiding this comment.
@CyrusNajmabadi Honestly, me too. Let me delete it and see if there are any failures that explains this.
There was a problem hiding this comment.
I'm guessing this got refactored over the years and ended up in this form without anybody realizing it.
There was a problem hiding this comment.
This goes back to b83e577
| { | ||
| return null; | ||
| } | ||
|
|
||
| var document = solution.GetDocument(doc.Id); |
There was a problem hiding this comment.
I am terrified to wonder how this code ever happened in the first place.
|
@CyrusNajmabadi My only concern is the that the original code ever existed in our codebase in the first place. |
jinujoseph
added
the
Community
|
Merging this so it's in this at least in going forward; we're still having a conversation about a backport for 16.9. |
|
And to follow up since a few other folks have ran into this: this will be fixed with 16.10. Based on internal schedules if we got a patch out for 16.9 it wouldn't get in your hands that much faster than just waiting for 16.10, so just best to sit tight and wait for a bit longer. |
Fixes #51633