Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InternalsVisibleTo for VS Mac #50449

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

davidwengier
Copy link
Member

Follow up to #50389

@CyrusNajmabadi
Copy link
Member

@sharwell to make sure this is how he wants thsi done (vs. something like EA pattern).

@davidwengier
Copy link
Member Author

External access has been looked at for VS for Mac but their use of Roslyn is extensive and its too much work.

Ironically though, this is adding an IVT to an external access project, just not the one that lives in this repo. It's weird :)

@davidwengier davidwengier merged commit b5bd697 into dotnet:master Jan 14, 2021
@davidwengier davidwengier deleted the VSMacIVT branch January 14, 2021 04:36
@ghost ghost added this to the Next milestone Jan 14, 2021
@sharwell
Copy link
Member

sharwell commented Jan 14, 2021

External access has been looked at for VS for Mac but their use of Roslyn is extensive and its too much work.

To clarify this point, VS for Mac explicitly opted out of the External Access process as part of an agreement that we are allowed to make changes that break VS for Mac, and that project is solely responsible for any resulting changes necessary to make things work again (i.e. there is no breaking changes policy on this boundary).

@Cosifne Cosifne modified the milestones: Next, 16.9 Jan 27, 2021
@JoeRobich JoeRobich modified the milestones: 16.9, 16.9.P4 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants