Dispose pooled object #50402
Merged
Dispose pooled object #50402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
approved these changes
Jan 12, 2021
Youssef1313
reviewed
Jan 12, 2021
| @@ -509,7 +509,7 @@ private static ImmutableArray<CompletionItemWithHighlight> GetHighlightedList(Li | |||
| ImmutableArray<CompletionFilterWithState> filters) | |||
| { | |||
| // See which filters might be enabled based on the typed code | |||
| var _ = PooledHashSet<CompletionFilter>.GetInstance(out var textFilteredFilters); | |||
| using var _ = PooledHashSet<CompletionFilter>.GetInstance(out var textFilteredFilters); | |||
There was a problem hiding this comment.
Shouldn't CA2000 catch such cases? Is it disabled for the repo?
There was a problem hiding this comment.
I never trusted CA2000 because it can't figure ownership transfer correctly.
There was a problem hiding this comment.
Yes, CA2000 is disabled for the repository.
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue found in #46983 (comment)