Use IEventListener to register workspaces for LSP instead of inside AbstractPackage #50387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered in MEF only vs extensibility
dibarbet
added
Area-IDE
LSP
dibarbet
force-pushed
the
fix_razor_workspace_registration
branch
from
58f19ee to
c8fd0c9
Compare
davidwengier
approved these changes
Jan 12, 2021
dibarbet
changed the title
ghost
merged commit 
ghost
added this to the 
|
Missed this earlier in my inbox but looks good! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @jasonmalinowski AbstractPackage initialization is only used for certain initialization paths (e.g. tools options, object browser, old project system com bits). In general other roslyn initialization is done via MEF and does not go through the UI thread bound package initialization.
So instead of registering workspaces in the package load (which doesn't match 1:1 with workspace creation) we instead register the workspaces exactly when they are created via the IEventListener infrastructure.
Fixes #50386