Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase maximum suggestions to 5, fixes #31002 #49687

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Increase maximum suggestions to 5, fixes #31002 #49687

merged 1 commit into from
Dec 2, 2020

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Dec 1, 2020

See #31002 for more context.

@ffMathy ffMathy requested a review from a team as a code owner December 1, 2020 11:55
@ffMathy ffMathy mentioned this pull request Dec 1, 2020
Closed
mavasani
mavasani previously requested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as blocked as #31002 is marked for design review.

@ffMathy
Copy link
Contributor Author

ffMathy commented Dec 1, 2020

@mavasani that makes sense, but since the current feature is rather useless until it is fixed, is there a way we can speed up the process priority-wise?

@ffMathy
Copy link
Contributor Author

ffMathy commented Dec 1, 2020

And can we accept "5" as a temporary solution until we have a proper design?

@mavasani
Copy link
Contributor

mavasani commented Dec 1, 2020

And can we accept "5" as a temporary solution until we have a proper design?

@ffMathy Kindly add the same comment on the issue, and I have no pushback on the change if you get the approval on that issue.

@ffMathy
Copy link
Contributor Author

ffMathy commented Dec 1, 2020

@mavasani gotcha - thank you very much!

CyrusNajmabadi
CyrusNajmabadi approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me.

@mavasani mavasani dismissed their stale review December 1, 2020 17:36

Have a Roslyn team member's approval.

@mavasani mavasani mentioned this pull request Dec 1, 2020
Closed
@ffMathy
Copy link
Contributor Author

ffMathy commented Dec 1, 2020

@CyrusNajmabadi thank you so much!

Is there anything I can do to make the build pass? Is it a transient issue?

@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 1, 2020
@CyrusNajmabadi CyrusNajmabadi merged commit d3f8648 into dotnet:master Dec 2, 2020
@ghost ghost added this to the Next milestone Dec 2, 2020
@CyrusNajmabadi
Copy link
Member

Thank you!

@dibarbet dibarbet modified the milestones: Next, 16.9.P3 Dec 19, 2020
@mikadumont mikadumont mentioned this pull request Jan 25, 2021
Closed
@ffMathy ffMathy deleted the patch-1 branch July 26, 2021 17:22
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Dec 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@mavasani mavasani mavasani left review comments

Assignees

@mavasani mavasani

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P3
Development

Successfully merging this pull request may close these issues.
6 participants
@ffMathy @mavasani @CyrusNajmabadi @dibarbet @jinujoseph @Dotnet-GitSync-Bot