Input param postconditions #49576
Merged
Input param postconditions #49576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
force-pushed
the
input-param-postconditions
branch
2 times, most recently
from
3474ceb to
8f8f037
Compare
RikkiGibson
force-pushed
the
input-param-postconditions
branch
from
8f8f037 to
e552f25
Compare
|
@dotnet/roslyn-compiler Please review |
|
@dotnet/roslyn-compiler Please review |
cston
reviewed
Dec 7, 2020
| @@ -5308,7 +5324,10 @@ private VisitArgumentResult VisitArgumentEvaluate(BoundExpression argument, RefK | |||
| stateForLambda: result.StateForLambda); | |||
|
|
|||
| // If the parameter has annotations, we perform an additional check for nullable value types | |||
There was a problem hiding this comment.
nullable value types [](start = 96, length = 20)
Is this just for nullable value types?
There was a problem hiding this comment.
Yes, for example in the case of a parameter [DisallowNull] string? s we can adjust the type to just string and then visit the conversion. But in the case of [DisallowNull] int? i we can't adjust the type in that way. SharpLab. Note particularly the difference in diagnostic IDs.
cston
approved these changes
Dec 7, 2020
|
The validation run passes CloudBuild so will merge this now. |
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48605
Closes #48134
Closes #49136
Implements the change described in dotnet/csharplang#4102 (comment). Also fixes a bug where a null-conditional expression with a type
T where T : class?had flow stateMaybeNullwhen it should actually have flow stateMaybeDefault.Note that while arguments to user-defined conversions have their state updated when the conversion causes a nullable warning, we don't actually honor the postcondition on the conversion parameter. Filed #49575 to follow-up-- I think parameter postconditions on a user-defined conversion are a pretty edge case, so probably won't prioritize it.