Implement proposal 1 for type substitution #49441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
force-pushed
the
type-substitution0
branch
3 times, most recently
from
199da77 to
5e4cf4f
Compare
jcouv
force-pushed
the
type-substitution0
branch
from
d655f4a to
30f9c6b
Compare
jcouv
force-pushed
the
type-substitution0
branch
from
2a81422 to
8956d51
Compare
This was referenced Nov 20, 2020
jcouv
force-pushed
the
type-substitution0
branch
from
ba91d3f to
7719499
Compare
|
Closing in favor of #49723 This approach (simplifying the core type substitution logic) has repercussions which feel risky: what symbols are definitions, symbol equality rules, ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal 1
Fixes #41368
VS validation build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4245812&view=results