Disable code cleanup in LSP

[allisonchou]

Code cleanup currently doesn't work in LSP - tracking issue here: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1094627
We should disable code cleanup for now.

Closes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1193339/

[allisonchou]

Note: I wasn't sure whether we would also have to disable code cleanup in the IVsHierarchyCodeCleanupScope case (mainly because I'm unsure exactly what it is) - currently it's just disabled in the text buffer case, which at least seems to fix the original bug.

[davidwengier]

This just skips applying the cleanup, correct? Is there a way we can tell the platform not to show the buttons too? Presumably right now the user can click them and just nothing happens, which is not good.

[allisonchou]

@davidwengier Hmm, not that I know of, but I could be wrong.
There's also a similar problem here when invoking the code cleanup keyboard shortcut Ctrl+K, Ctrl+E, i.e. nothing would happen. edit: I guess we could possibly give the user an error message, but this would involve the UI thread (I think?).

cc @CyrusNajmabadi, would you happen to know whether there's a way to hide the code cleanup button in this scenario?

[dibarbet]

@allisonchou see #44409 for hiding the broom. afaik there is not currently a good way.

[allisonchou]

@dibarbet Thanks! I left a comment on the original bug asking for the current status of being able to hide unsupported features.
In the meantime, should the CC feature be disabled? I feel like having a button/command that doesn't work is preferable to breaking user code.

[dibarbet]

I feel like having a button/command that doesn't work is preferable to breaking user code.

Yep, I'm fine with that.

[davidwengier]

I, also, agree.