Improve resilience to COM RCW cleanup issues in tests #49047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
requested changes
Oct 29, 2020
There was a problem hiding this comment.
@sharwell Can this pull request be updated to describe the problems that we are trying to improve? Otherwise it's unclear what the goal is.
|
Marking as draft since it didn't fix the integration test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis of heap dumps in #49024 suggests that the test process is attempting to clean up COM RCWs after the STA thread is no longer available. Local testing suggests a strategy of aborting the STA thread during an AppDomain unload request mitigates the delays.