Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of uses of a PooledHashSet(Of Symbol) #48978

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Couple of uses of a PooledHashSet(Of Symbol) #48978

merged 1 commit into from
Nov 12, 2020

Conversation

AdamSpeight2008
Copy link
Contributor

Make use of PooledHashSet rather that creating a new instance each time.

@AdamSpeight2008
Update SemanticModel.vb
d5ccda4 
Make use of `PooledHashSet` rather that creating a new instance each time.
@AdamSpeight2008 AdamSpeight2008 requested a review from a team as a code owner October 28, 2020 15:27
333fred
333fred approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/roslyn-compiler for a second review

@333fred 333fred added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 28, 2020
@runfoapp runfoapp bot mentioned this pull request Oct 29, 2020
Closed
@333fred 333fred merged commit dff9639 into dotnet:master Nov 12, 2020
@ghost ghost added this to the Next milestone Nov 12, 2020
@333fred
Copy link
Member

333fred commented Nov 12, 2020

Thanks @AdamSpeight2008

@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@AdamSpeight2008 AdamSpeight2008 deleted the patch-11 branch August 5, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamSpeight2008 @333fred @cston @allisonchou @Dotnet-GitSync-Bot