Further optimize FindValidCloneMethod #48949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
changed the title
dotnet#48935 optimizes one path that hits FindValidCloneMethod, but there are others that could do with the same fast-path optimization. In order to accomplish that, I introduced a new HasPossibleCloneMethod on NamedTypeSymbol, that returns whether the type _could_ have a method on it that is a valid clone method. For source types, this is a quick syntax check to see if it's a record. For metadata types, it's a check on just the member names for something with the right name. This should prevent us from unnecessarily loading all method signatures from metadata unnecessarily whenever we check for a clone method.
333fred
force-pushed
the
isrecord-optimize-further
branch
from
7d026ce to
a3ada0c
Compare
|
@AlekseyTs @dotnet/roslyn-compiler this is ready for review. |
|
@dotnet/roslyn-compiler for reviews please. |
jaredpar
reviewed
Oct 28, 2020
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
Outdated
Show resolved
Hide resolved
| @@ -349,6 +349,7 @@ internal override bool IsInterface | |||
| internal sealed override NamedTypeSymbol NativeIntegerUnderlyingType => null; | |||
|
|
|||
| internal override bool IsRecord => false; | |||
| internal override bool HasPossibleWellKnownCloneMethod() => false; | |||
There was a problem hiding this comment.
How are records represented in the EE? This line caught me a bit off guard. Must be I don't have the full pictuer here.
There was a problem hiding this comment.
I'm not sure how records are represented in EE, but this doesn't particularly change whatever it is. @tmat, does EE have records support? If so, we likely need to file a separate bug and make a change here.`
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 30, 2020
AlekseyTs
reviewed
Oct 30, 2020
src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PENamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 30, 2020
src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedContainer.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 30, 2020
src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedEmbeddedAttributeSymbol.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 30, 2020
src/Compilers/CSharp/Portable/Symbols/Wrapped/WrappedNamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
|
Done with review pass (iteration 3) #Closed |
… implementations, seal where possible.
|
@AlekseyTs @jaredpar addressed feedback. |
jaredpar
approved these changes
Nov 2, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48935 optimizes one path that hits FindValidCloneMethod, but there are others that could do with the same fast-path optimization. In order to accomplish that, I introduced a new HasPossibleCloneMethod on NamedTypeSymbol, that returns whether the type could have a method on it that is a valid clone method. For source types, this is a quick syntax check to see if it's a record. For metadata types, it's a check on just the member names for something with the right name. This should prevent us from unnecessarily loading all method signatures from metadata whenever we check for a clone method