Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EditorFeatures.Cocoa #48866

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Add EditorFeatures.Cocoa #48866

merged 4 commits into from
Oct 26, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 22, 2020 •
edited
Loading

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tmat tmat force-pushed the TextCocoa branch 2 times, most recently from c9801c5 to 1f9b4ce Compare October 22, 2020 23:35
This was referenced Oct 23, 2020
Closed
Closed
@KirillOsenkov
Copy link
Member

@DavidKarlas @Therzok @davidwengier @gundermanc @olegtk FYI

sharwell
sharwell reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The PublicAPI files appear to be added as binary instead of text. They should be re-saved as utf-8-bom.

@tmat tmat force-pushed the TextCocoa branch 3 times, most recently from d79c28b to b9fdb77 Compare October 24, 2020 17:22
@tmat tmat marked this pull request as ready for review October 26, 2020 17:03
@tmat tmat requested review from a team as code owners October 26, 2020 17:03
@tmat tmat merged commit 80845e8 into dotnet:master Oct 26, 2020
@ghost ghost added this to the Next milestone Oct 26, 2020
@tmat tmat deleted the TextCocoa branch October 26, 2020 17:56
@jasonmalinowski
Copy link
Member

@tmat Just to confirm, I see there's a bunch of files that seem cloned in this PR. I presume the sequence of events was:

  1. The files used to live in the Wpf layer.
  2. It got cloned into the Cocoa layer in the past rather than refactoring.
  3. We're migrating that repository verbatim into our repo.
  4. Now that it's here we can cleanup/deduplicate as appropriate.

Is that correct?

@KirillOsenkov
Copy link
Member

Yes, Cocoa was a fork of EditorFeatures.Wpf which first lived in the VSMac repo, then got moved to the VS-Platform repo (for expediency) and now found it's best home in the Roslyn repo.

@runfoapp runfoapp bot mentioned this pull request Oct 29, 2020
Closed
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@davidwengier davidwengier mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.
6 participants
@tmat @Dotnet-GitSync-Bot @KirillOsenkov @jasonmalinowski @sharwell @allisonchou