Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default constructor suggestion between members (#48318) #48503

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

weitzhandler
Copy link
Contributor

Fixes #48318

@weitzhandler weitzhandler force-pushed the dev/shimmy/issue-48318 branch from c2de970 to 3c92eba Compare October 11, 2020 21:44
@weitzhandler weitzhandler marked this pull request as ready for review October 11, 2020 21:44
@weitzhandler weitzhandler requested a review from a team as a code owner October 11, 2020 21:44
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 12, 2020
@davidwengier davidwengier merged commit 941dc7e into dotnet:master Oct 13, 2020
@ghost ghost added this to the Next milestone Oct 13, 2020
@davidwengier
Copy link
Member

Thanks for the contribution!

@weitzhandler weitzhandler deleted the dev/shimmy/issue-48318 branch October 13, 2020 12:01
333fred added a commit that referenced this pull request Oct 13, 2020
…features/interpolated-string-constants

* upstream/master: (295 commits)
  Update F1 Keywords to differentiate between semantics of default keyword (#48500)
  Default constructor suggestion between members (#48318) (#48503)
  Adjust ERR_PartialMisplaced diagnostic message (#48524)
  Refactor ChangedText.Merge and add fuzz testing (#48420)
  Apply suggestions from code review
  Do not crash on unexpected exception (#48367)
  Reference the contributing doc in 'Analyzer Suggestion' issue template
  Apply suggestions from code review
  Hardcode skipped Regex diagnostic ID as it is not available in CodeStyle layer
  Add using
  Skip help link for Regex diagnostic analyzer
  Add contributing doc for IDE code style analyzer documentation
  Make db lock static to investigate issue.
  Update dependencies from https://github.com/dotnet/roslyn build 20201012.2 (#48513)
  Hook up help link even for AbstractCodeQualityDiagnosticAnalyzer
  Add destructor intellisense test for record (#48297)
  Remove unused method (#48429)
  Fix bug
  Update src/EditorFeatures/Core.Wpf/InlineHints/InlineHintsTag.cs
  Add more test
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Oct 13, 2020
* upstream/master: (68 commits)
  Update F1 Keywords to differentiate between semantics of default keyword (dotnet#48500)
  Default constructor suggestion between members (dotnet#48318) (dotnet#48503)
  Adjust ERR_PartialMisplaced diagnostic message (dotnet#48524)
  Refactor ChangedText.Merge and add fuzz testing (dotnet#48420)
  Apply suggestions from code review
  Do not crash on unexpected exception (dotnet#48367)
  Reference the contributing doc in 'Analyzer Suggestion' issue template
  Apply suggestions from code review
  Hardcode skipped Regex diagnostic ID as it is not available in CodeStyle layer
  Add using
  Skip help link for Regex diagnostic analyzer
  Add contributing doc for IDE code style analyzer documentation
  Make db lock static to investigate issue.
  Update dependencies from https://github.com/dotnet/roslyn build 20201012.2 (dotnet#48513)
  Hook up help link even for AbstractCodeQualityDiagnosticAnalyzer
  Add destructor intellisense test for record (dotnet#48297)
  Remove unused method (dotnet#48429)
  Fix bug
  Update src/EditorFeatures/Core.Wpf/InlineHints/InlineHintsTag.cs
  Add more test
  ...
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest adding constructor inside class as well, not only when cursor is on class name
4 participants