Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't offer to remove as cast from using statements or declarations #48110

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Don't offer to remove as cast from using statements or declarations #48110

merged 1 commit into from
Sep 28, 2020

Conversation

davidwengier
Copy link
Member

Fixes #45596

@davidwengier davidwengier merged commit d3131e5 into dotnet:master Sep 28, 2020
@davidwengier davidwengier deleted the DontRemoveAsCastFromUsing branch September 28, 2020 07:17
@ghost ghost added this to the Next milestone Sep 28, 2020
333fred added a commit that referenced this pull request Sep 28, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merges/master-to-…
858ff35 
…features/interpolated-string-constants

* upstream/master: (1950 commits)
  Delete extra "Return True" (#48089)
  Remove unused param
  Extract local
  Update help service to account for all `TypeDeclarationSyntax` (namespace+record+struct) as partial type (#48095)
  Don't offer to remove as cast from using statements or declarations (#48110)
  Cleaner solution
  Update tests
  Don't offer to remove necessary native integer casts
  Fix xml attribute name classification
  Use switch expressions.
  Add test for IAsyncEnumerable<string>
  Fix tests
  Add tests
  Update CSharpTypeInferenceService.TypeInferrer.cs
  Fix failure to dispose RemoteWorkspace in tests
  [master] Update dependencies from dotnet/roslyn (#48072)
  Simplify common calls to Parallel.For with a RoslynParallel.For helper
  Fallback to IEnumerable<> if IAsyncEnumerable<> not found
  Fix cancellation handling in Parallel.For
  Update InferTypeInForEachStatement to respect await foreach
  ...
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.

IDE0019 Syntactic Sugar Quick Fix creates functionally different code that can introduce a memory leak
3 participants
@davidwengier @CyrusNajmabadi @Cosifne