Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable source generator integration test #47305

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Enable source generator integration test #47305

merged 1 commit into from
Nov 13, 2020

Conversation

jasonmalinowski
Copy link
Member

@jasonmalinowski jasonmalinowski commented Aug 31, 2020 •
edited
Loading

Closes #47255

@jasonmalinowski jasonmalinowski requested a review from a team as a code owner August 31, 2020 18:57
@jasonmalinowski jasonmalinowski self-assigned this Aug 31, 2020
@jasonmalinowski jasonmalinowski marked this pull request as draft August 31, 2020 18:57
@jasonmalinowski jasonmalinowski removed the request for review from a team August 31, 2020 18:57
@jinujoseph jinujoseph added Area-IDE Test Test failures in roslyn-CI labels Sep 25, 2020
@jasonmalinowski jasonmalinowski force-pushed the enable-integration-test-for-source-generators branch from f592d72 to 47b3bbc Compare October 6, 2020 19:35
@jasonmalinowski jasonmalinowski force-pushed the enable-integration-test-for-source-generators branch from 47b3bbc to bc241f1 Compare October 20, 2020 18:31
@jasonmalinowski jasonmalinowski force-pushed the enable-integration-test-for-source-generators branch from bc241f1 to ee6e6f0 Compare October 29, 2020 01:35
This was referenced Oct 29, 2020
Closed
Closed
@jasonmalinowski jasonmalinowski force-pushed the enable-integration-test-for-source-generators branch from ee6e6f0 to 89784f9 Compare October 30, 2020 01:22
@runfoapp runfoapp bot mentioned this pull request Oct 30, 2020
Closed
@jasonmalinowski jasonmalinowski force-pushed the enable-integration-test-for-source-generators branch 2 times, most recently from 411da78 to c973fde Compare November 3, 2020 23:30
@jasonmalinowski jasonmalinowski force-pushed the enable-integration-test-for-source-generators branch 2 times, most recently from cd15371 to b79ba71 Compare November 13, 2020 18:58
@jasonmalinowski jasonmalinowski marked this pull request as ready for review November 13, 2020 20:32
@jasonmalinowski
Copy link
Member Author

jasonmalinowski commented Nov 13, 2020 •
edited
Loading

This was blocked by the change to require generators to be written in a netstandard/netcore assembly, and also there was some flakiness we were seeing. The netstandard/netcore assembly issue was addressed in 797d89f; the flakiness is gone and there's a few explanations but none entirely clear.

@jasonmalinowski jasonmalinowski merged commit a4a1b7e into dotnet:master Nov 13, 2020
@ghost ghost added this to the Next milestone Nov 13, 2020
@jasonmalinowski jasonmalinowski deleted the enable-integration-test-for-source-generators branch November 13, 2020 20:59
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.

Get the CSharpSourceGenerators integration test passing
4 participants
@jasonmalinowski @ryzngard @jinujoseph @allisonchou