Relax enforcement on conditional nullability attributes #46201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Nullable Reference Types
cston
approved these changes
Jul 24, 2020
|
Tagging @RikkiGibson for a second review. Thanks |
RikkiGibson
reviewed
Jul 27, 2020
| @@ -128481,6 +128447,42 @@ public new void M1<T>(System.Nullable<T?> x) | |||
| ); | |||
| } | |||
|
|
|||
| [Fact, WorkItem(43071, "https://github.com/dotnet/roslyn/issues/43071")] | |||
There was a problem hiding this comment.
Does the implementation change affect behavior of this test?
There was a problem hiding this comment.
No behavior change to this test, I'm just adding a test to close a different issue.
RikkiGibson
reviewed
Jul 27, 2020
| @@ -610,11 +605,6 @@ void enforceNotNullWhenForPendingReturn(PendingBranch pendingReturn, BoundExpres | |||
| enforceParameterNotNullWhen(returnStatement.Syntax, parameters, sense: true, stateWhen: pendingReturn.StateWhenTrue); | |||
| enforceParameterNotNullWhen(returnStatement.Syntax, parameters, sense: false, stateWhen: pendingReturn.StateWhenFalse); | |||
| } | |||
| else | |||
| { | |||
| enforceParameterNotNullWhen(returnStatement.Syntax, parameters, sense: true, stateWhen: pendingReturn.State); | |||
There was a problem hiding this comment.
So this works because we enter a split state after visiting a bool constant, right?
RikkiGibson
approved these changes
Jul 27, 2020
ghost
modified the milestones:
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44080
For example: in
void M([NotNullWhen(true)] out string? s) { s = null; return ...; }we should complain in areturn true;scenario, but not in areturn SomeBoolValue();scenario.