Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect diagnostic message for "using" #39003

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Fix incorrect diagnostic message for "using" #39003

merged 1 commit into from
Dec 13, 2019

Conversation

bgrainger
Copy link
Contributor

This removes the incorrect phrase " or implement a suitable 'Dispose' method" when using a type that doesn't implement IDisposable.

For #33746.

@bgrainger bgrainger requested a review from a team as a code owner October 2, 2019 20:28
@bgrainger bgrainger force-pushed the fix-idisposable-message branch from 523ce4c to 19fddd5 Compare October 2, 2019 21:02
@jcouv jcouv added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 3, 2019
@RikkiGibson RikkiGibson requested a review from chsienki October 3, 2019 19:54
@RikkiGibson
Copy link
Contributor

PTAL @chsienki. Is this phrasing more like what we want? Should we mention pattern Dispose with ref structs or is it excessive diagnostic noise for something fairly niche?

@RikkiGibson RikkiGibson added this to the 16.4.P3 milestone Oct 3, 2019
@333fred
Copy link
Member

333fred commented Oct 3, 2019

I think this wording is good, trying to elaborate about ref structs is a bit unnecessary.

@bgrainger
Copy link
Contributor Author

To be clear, this PR reverts the message to what it used to be before 91a119b#diff-eac3afc2449ebcd568f92bea7d52d604.

@jinujoseph jinujoseph removed this from the 16.4.P3 milestone Dec 12, 2019
@chsienki chsienki merged commit 4ab85dd into dotnet:master Dec 13, 2019
@333fred
Copy link
Member

333fred commented Dec 13, 2019

@bgrainger sorry for the delay, and thanks for the contribution!

@bgrainger bgrainger deleted the fix-idisposable-message branch December 13, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bgrainger @RikkiGibson @333fred @chsienki @jinujoseph @jcouv