Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Criteria for "Add Usings On Paste" to be enabled by default #49444

Closed
1 of 3 tasks
ryzngard opened this issue Nov 17, 2020 · 3 comments
Closed
1 of 3 tasks

Criteria for "Add Usings On Paste" to be enabled by default #49444

ryzngard opened this issue Nov 17, 2020 · 3 comments
Assignees
@ryzngard
Labels
Area-IDE Story
Milestone
17.3

Comments

@ryzngard
Copy link
Contributor

ryzngard commented Nov 17, 2020 •
edited
Loading

This will track the criteria needed for add usings on paste to be enabled by default. Once all are completed, we should change the default to enabled.
@ryzngard ryzngard added this to the 16.9 milestone Nov 17, 2020
@ryzngard ryzngard self-assigned this Nov 17, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 17, 2020
@jinujoseph jinujoseph added Story and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 17, 2020
@ryzngard ryzngard mentioned this issue Nov 17, 2020
Merged
ryzngard added a commit that referenced this issue Nov 20, 2020
@ryzngard
Add usings on paste (#48501)
8d278c2 
Addresses #45853

Hook up paste command to also automatically add usings. Operation uses thread await dialog to pop up to a user if it is taking a while with a "cancel" button. The dialog will not always show, but follows the IUIThreadOperationContext scope rules

Edit:

This is disabled by default. The following followup issues were filed
#49442
#49443
#49444
@jinujoseph jinujoseph modified the milestones: 16.9, 16.10 Mar 28, 2021
@ryzngard
Copy link
Contributor Author

ryzngard commented Jun 23, 2021 •
edited
Loading

image

@ryzngard
Copy link
Contributor Author

From Design Review:

We're okay with enabling this for now with current perf numbers. We will enable in dev17 by default and continue to monitor perf. One action item we have is to investigate if we can instruct the user on how to disable in the thread await dialog that would popup for long running tasks.

@ryzngard ryzngard modified the milestones: 16.10, 17.0.P2 Jun 24, 2021
@jinujoseph jinujoseph modified the milestones: 17.0.P2, 17.0 Jul 16, 2021
@ryzngard
Copy link
Contributor Author

We're keeping disabled by default until we can finish async work and not block the UI thread.

@ryzngard ryzngard modified the milestones: 17.0, 17.1 Oct 11, 2021
@jinujoseph jinujoseph modified the milestones: 17.1, 17.3 Apr 27, 2022
@sharwell sharwell moved this to Complete in IDE: Design review Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzngard ryzngard

Labels
Area-IDE Story
Projects
IDE: Design review
Archived in project
Milestone
17.3
Development

No branches or pull requests
3 participants
@ryzngard @jinujoseph @Dotnet-GitSync-Bot