Remove prototype comments

dotnet · Feb 12, 2021 · fa751a9 · fa751a9
1 parent 9d16f63
commit fa751a9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ForEachStatement.cs b/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ForEachStatement.cs
@@ -266,7 +266,7 @@ private BoundStatement WrapWithTryFinallyDispose(
             {
                 TryGetDisposeMethod(forEachSyntax, enumeratorInfo, out disposeMethod); // interface-based
 
-                // PROTOTYPE(UsedAssemblyReferences): This is a temporary workaround for https://github.com/dotnet/roslyn/issues/39948
+                // This is a temporary workaround for https://github.com/dotnet/roslyn/issues/39948
                 if (disposeMethod is null)
                 {
                     return rewrittenBody;

diff --git a/src/Compilers/CSharp/Test/Emit/Emit/EndToEndTests.cs b/src/Compilers/CSharp/Test/Emit/Emit/EndToEndTests.cs
@@ -97,7 +97,8 @@ bool runTestAndCatch(int depth)
         // This test is a canary attempting to make sure that we don't regress the # of fluent calls that 
         // the compiler can handle. 
         [WorkItem(16669, "https://github.com/dotnet/roslyn/issues/16669")]
-        [ConditionalFact(typeof(WindowsOrLinuxOnly), AlwaysSkip = "PROTOTYPE(UsedAssemblyReferences): skipping to unblock metge from master."), WorkItem(34880, "https://github.com/dotnet/roslyn/issues/34880")]
+        [WorkItem(51196, "https://github.com/dotnet/roslyn/issues/51196")]
+        [ConditionalFact(typeof(WindowsOrLinuxOnly), AlwaysSkip = "https://github.com/dotnet/roslyn/issues/51196: skipping to unblock merge."), WorkItem(34880, "https://github.com/dotnet/roslyn/issues/34880")]
         public void OverflowOnFluentCall()
         {
             int numberFluentCalls = (ExecutionConditionUtil.Architecture, ExecutionConditionUtil.Configuration) switch
@@ -149,7 +150,8 @@ void M2() {
             }
         }
 
-        [Fact(Skip = "PROTOTYPE(UsedAssemblyReferences): skipping to unblock metge from master.")]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/51196: skipping to unblock merge.")]
+        [WorkItem(51196, "https://github.com/dotnet/roslyn/issues/51196")]
         [WorkItem(33909, "https://github.com/dotnet/roslyn/issues/33909")]
         [WorkItem(34880, "https://github.com/dotnet/roslyn/issues/34880")]
         public void DeeplyNestedGeneric()
@@ -229,7 +231,8 @@ public static void Main(string[] args)
             }
         }
 
-        [ConditionalFact(typeof(WindowsOrLinuxOnly), AlwaysSkip = "PROTOTYPE(UsedAssemblyReferences): skipping to unblock metge from master.")]
+        [ConditionalFact(typeof(WindowsOrLinuxOnly), AlwaysSkip = "https://github.com/dotnet/roslyn/issues/51196: skipping to unblock merge.")]
+        [WorkItem(51196, "https://github.com/dotnet/roslyn/issues/51196")]
         public void NestedIfStatements()
         {
             int nestingLevel = (ExecutionConditionUtil.Architecture, ExecutionConditionUtil.Configuration) switch
@@ -275,7 +278,8 @@ static void Main()
         }
 
         [WorkItem(42361, "https://github.com/dotnet/roslyn/issues/42361")]
-        [ConditionalFact(typeof(WindowsOrLinuxOnly), AlwaysSkip = "PROTOTYPE(UsedAssemblyReferences): skipping to unblock metge from master.")]
+        [ConditionalFact(typeof(WindowsOrLinuxOnly), AlwaysSkip = "https://github.com/dotnet/roslyn/issues/51196: skipping to unblock merge.")]
+        [WorkItem(51196, "https://github.com/dotnet/roslyn/issues/51196")]
         public void Constraints()
         {
             int n = (ExecutionConditionUtil.Architecture, ExecutionConditionUtil.Configuration) switch

diff --git a/src/Compilers/Core/Portable/Binding/BindingDiagnosticBag.cs b/src/Compilers/Core/Portable/Binding/BindingDiagnosticBag.cs
@@ -17,7 +17,7 @@ namespace Microsoft.CodeAnalysis
     /// This is base class for a bag used to accumulate information while binding is performed.
     /// Including diagnostic messages and dependencies in the form of "used" assemblies. 
     /// </summary>
-    internal abstract class BindingDiagnosticBag // PROTOTYPE(UsedAssemblyReferences): Is there a better name for this and the derived types?
+    internal abstract class BindingDiagnosticBag
     {
         public readonly DiagnosticBag? DiagnosticBag;
 
@@ -56,7 +56,6 @@ internal void Add(Diagnostic diag)
         }
     }
 
-    // PROTOTYPE(UsedAssemblyReferences): Measure performance impact of collecting more information during binding by using this class.
     internal abstract class BindingDiagnosticBag<TAssemblySymbol> : BindingDiagnosticBag
         where TAssemblySymbol : class, IAssemblySymbolInternal
     {