Merge pull request #49089 from dibarbet/remove_myget_references

Cleanup remaining myget references
dotnet · Oct 31, 2020 · d7048e7 · d7048e7
2 parents 097e4ad + d5b3ae1
commit d7048e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/eng/publish-assets.ps1 b/eng/publish-assets.ps1
@@ -1,4 +1,4 @@
-# Publishes our build assets to nuget, myget, dotnet/versions, etc ..
+# Publishes our build assets to nuget, Azure DevOps, dotnet/versions, etc ..
 #
 # The publish operation is best visioned as an optional yet repeatable post build operation. It can be
 # run anytime after build or automatically as a post build step. But it is an operation that focuses on
@@ -18,8 +18,7 @@ Param(
   [string]$gitHubUserName = "",
   [string]$gitHubToken = "",
   [string]$gitHubEmail = "",
-  [string]$nugetApiKey = "",
-  [string]$myGetApiKey = ""
+  [string]$nugetApiKey = ""
 )
 Set-StrictMode -version 2.0
 $ErrorActionPreference="Stop"
@@ -28,7 +27,6 @@ $ErrorActionPreference="Stop"
 function Get-PublishKey([string]$uploadUrl) {
   $url = New-Object Uri $uploadUrl
   switch ($url.Host) {
-    "dotnet.myget.org" { return $myGetApiKey }
     "api.nuget.org" { return $nugetApiKey }
     # For publishing to azure, the API key can be any non-empty string as authentication is done in the pipeline.
     "pkgs.dev.azure.com" { return "AzureArtifacts"}

diff --git a/scripts/GenerateSdkPackages/README.md b/scripts/GenerateSdkPackages/README.md
@@ -1,11 +1,9 @@
 # Generate SDK Packages
 
-This is a collection of tools for generating a set of NuGet packages for the VS SDK and updating our repo to consume 
-them.  This is a temporary solution until we work with the VS SDK team to help address a couple of issues with how their 
+This is a tool for generating a set of NuGet packages for the VS SDK.  This is a temporary solution until we work with the VS SDK team to help address a couple of issues with how their 
 packages are produced.
 
 - make-all.ps1: Generates all of the NuGet packages we need for the VS SDK
-- change-all.ps1: Changes all our project.json files to reference a new VS SDK version 
 
 ## Example workflow
 
@@ -21,19 +19,15 @@ This will create all of the packages with the version string 15.0.26418-alpha.
 When building packages from a non-release branch (e.g. vsucorediag) use ```-versionSuffix branch-name``` to avoid potential 
 conflicts with release branch versions.
 
-Next the build needs to be updated to reflect this change in version for the packages we are consuming. 
-
-``` powershell
-> .\change-all.ps1 -version "26418.00" 
-```
-
-Before uploading the packages to myget please do a local build to validate the changes.  In order to do this the 
+Before uploading the packages to Azure DevOps please do a local build to validate the changes.  In order to do this the 
 following line needs to be added to NuGet.config.  Do not merge this change, it is for testing only.  
 
 ``` xml
 <add key="DO NOT MERGE" value="c:\users\jaredpar\temp\nuget" />
 ```
 
+Then update the version in `Versions.props` to match the newly generated version.
+
 Given this entry we can quickly run the following developer flow to validate the changes:
 
 ``` cmd
@@ -43,8 +37,8 @@ Given this entry we can quickly run the following developer flow to validate the
 > Test.cmd
 ```
 
-Assuming this all passes then revert the change to NuGet.config, upload the packages to the roslyn-tools feed of 
-myget and submit the result of `change-all.ps1` as a PR. 
+Assuming this all passes then revert the change to NuGet.config, upload the packages to the [public vs-impl feed](https://dev.azure.com/azure-public/vside/_packaging?_a=feed&feed=vs-impl) 
+and submit the result as a PR.