Remove if. Fix retargeting option

dotnet · Feb 26, 2021 · 1b2eb98 · 1b2eb98
1 parent ac45f85
commit 1b2eb98
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/Compilers/CSharp/Portable/Symbols/Retargeting/RetargetingSymbolTranslator.cs b/src/Compilers/CSharp/Portable/Symbols/Retargeting/RetargetingSymbolTranslator.cs
@@ -74,7 +74,7 @@ private FieldSymbol CreateRetargetingField(Symbol symbol)
                     tupleErrorField.Name,
                     tupleErrorField.TupleElementIndex,
                     tupleErrorField.Locations.IsEmpty ? null : tupleErrorField.Locations[0],
-                    this.RetargetingTranslator.Retarget(tupleErrorField.TypeWithAnnotations, RetargetOptions.RetargetPrimitiveTypesByName),
+                    this.RetargetingTranslator.Retarget(tupleErrorField.TypeWithAnnotations, RetargetOptions.RetargetPrimitiveTypesByTypeCode),
                     tupleErrorField.GetUseSiteInfo().DiagnosticInfo,
                     tupleErrorField.IsImplicitlyDeclared,
                     retargetedCorrespondingDefaultFieldOpt);

diff --git a/src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs b/src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
@@ -1503,13 +1503,6 @@ internal void AssertMemberExposure(Symbol member, bool forDiagnostics = false)
                 return;
             }
 
-            if (member is FieldSymbol && this.IsTupleType)
-            {
-                Debug.Assert(forDiagnostics);
-                return; // There are dangling tuple elements, probably related to https://github.com/dotnet/roslyn/issues/43597
-                        // and will be addressed by a pending PR https://github.com/dotnet/roslyn/pull/44231.
-            }
-
             Debug.Assert(false, "Premature symbol exposure.");
         }