Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused keyvault-related projects #1110

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

RikkiGibson
Copy link
Contributor

In the process of updating the Roslyn key vault URL I identified projects which I believe are no longer used and went ahead and deleted them.

@AbhitejJohn for confirmation that your team doesn't depend on any of the deleted projects here.

cc @JoeRobich for review

@JoeRobich
Copy link
Member

@RikkiGibson Should update linux image to 'ubuntu-latest', 16.04 is no longer available.

@RikkiGibson
Copy link
Contributor Author

@JoeRobich did you have any further concerns?

@JoeRobich
Copy link
Member

@JoeRobich did you have any further concerns?

I think this is good to merge once we get confirmation from @AbhitejJohn or @shyamnamboodiripad that we aren't breaking Unit Testing infra.

Copy link
Contributor

@AbhitejJohn AbhitejJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The VSTSMergeTool is something we tried building in the past but I think we'd want to build on the existing logic to merge PRs across branches to include AzDO support as well.

@JoeRobich
Copy link
Member

Thanks @AbhitejJohn!

@RikkiGibson RikkiGibson merged commit 7ba6e54 into dotnet:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants