Continue analysis even RuntimeInformation, OSPlatofrm types not loaded #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4281 +/- ##
=========================================
Coverage ? 95.80%
=========================================
Files ? 1168
Lines ? 265259
Branches ? 15985
=========================================
Hits ? 254143
Misses ? 9095
Partials ? 2021 |
mavasani
reviewed
Oct 2, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Oct 2, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Oct 2, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Oct 2, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Oct 2, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
approved these changes
Oct 2, 2020
Evangelink
reviewed
Oct 3, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
commented
Oct 5, 2020
...ft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.GuardedCallsTests.cs
Outdated
Show resolved
Hide resolved
buyaa-n
commented
Oct 5, 2020
...ft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.GuardedCallsTests.cs
Outdated
Show resolved
Hide resolved
|
I have tested runtime build by enabling the analyzer when other types ( While doing that test found a bug: IOOB exception thrown when the OSPlatform type is not loaded which is silently swallowed by the IDE and no more diagnostics take place. Fixed the bug, now this PR is ready for merge @mavasani if you would like to take another look |
|
Gonna merge it now if there are any questions/comments feel free to add, will apply/answer then separately |
This was referenced Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of dotnet/runtime#42335 we need to ensure that each of runtime projects can produce warnings/errors from the platform compat analyzer during a normal build. There are several projects not having access to the System.Runtime.InteropServices.RuntimeInformation, System.Runtime.InteropServices.OSPlatofrm which are used as one of the guard methods for the analzyer. Normally we bail out when any of the types used for the analysis is not loaded/found, but the types mentioned are not essential for the analysis we want to continue the analysis in that case and get warnings if there is any.