Ensure we include the line count and end char index in remapped spans #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/razor-compiler for reviews. /cc @ryzngard |
ryzngard
approved these changes
Jan 25, 2024
DustinCampbell
approved these changes
Jan 26, 2024
jaredpar
reviewed
Jan 26, 2024
| @@ -564,7 +564,7 @@ private static SourceSpan RemapFilePathIfNecessary(SourceSpan sourceSpan, CodeRe | |||
| // If you try and use the line pragma in the design time docs to map back to the original file it will fail, | |||
| // as the path isn't actually valid on windows. As a workaround we apply a simple heuristic to switch the | |||
| // paths back when writing out the design time paths. | |||
| sourceSpan = new SourceSpan(sourceSpan.FilePath.Replace("/", "\\"), sourceSpan.AbsoluteIndex, sourceSpan.LineIndex, sourceSpan.CharacterIndex, sourceSpan.Length); | |||
| sourceSpan = new SourceSpan(sourceSpan.FilePath.Replace("/", "\\"), sourceSpan.AbsoluteIndex, sourceSpan.LineIndex, sourceSpan.CharacterIndex, sourceSpan.Length, sourceSpan.LineCount, sourceSpan.EndCharacterIndex); | |||
There was a problem hiding this comment.
Shouldn't we have a test for this?
There was a problem hiding this comment.
We do have tests, but they were all at the start of the doc so the baseline didn't actually change. I'll add a test that covers it.
|
@jaredpar for any other feedback |
jaredpar
approved these changes
Jan 30, 2024
chsienki
added a commit
to chsienki/razor-tooling
that referenced
this pull request
Jan 31, 2024
…dotnet#9863) * Ensure we include the line count and end char index in remapped spans * Make the source span in tests have non-default values to ensure they get mapped too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we include the line count and end char index in remapped spans
Fixes #9827