Share formatting tests between cohosting and LSP server #11264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't exist in cohosting, so can't be shared
On my machine this caused 0 difference in test time, and XUnit fixtures seem at odds with creating custom test discoverers, which I want to do to add fuse testing to cohosting.
This commit was purely mechanical, no changes to any test inputs or outputs. The old file name differentiation made no sense, and its easier to share a single file.
RazorLSPOptions doesn't make sense in cohosting
This makes the test count between the two systems the same, for easy validation that we're doing the right thing
My assumption at the start, that it would be incompatible, was incorrect.
DustinCampbell
approved these changes
Dec 4, 2024
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingTestAttribute.cs
Outdated
Show resolved
Hide resolved
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingTestAttribute.cs
Outdated
Show resolved
Hide resolved
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingFactDiscoverer.cs
Outdated
Show resolved
Hide resolved
| [XunitTestCaseDiscoverer("Microsoft.AspNetCore.Razor.Test.Common." + nameof(FormattingFactDiscoverer), "Microsoft.AspNetCore.Razor.Test.Common")] | ||
| internal class FormattingTestFactAttribute : FactAttribute | ||
| { | ||
| public bool SkipFlipLineEnding { get; set; } |
There was a problem hiding this comment.
🚲 bike-shedding: should this just be ShouldFilpLineEnding and have a default value of true?
There was a problem hiding this comment.
Going to agree to disagree here, Skip feels more "standard" in the test attribute usage itself.
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Formatting/FormattingTestTheoryAttribute.cs
Outdated
Show resolved
Hide resolved
src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/FormattingTestBase.cs
Outdated
Show resolved
Hide resolved
src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/FormattingTestBase.cs
Outdated
Show resolved
Hide resolved
src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/FormattingTestBase.cs
Outdated
Show resolved
Hide resolved
...r/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingTestBase.cs
Outdated
Show resolved
Hide resolved
...r/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/FormattingTestBase.cs
Outdated
Show resolved
Hide resolved
For you, and for me, and the entire human race
|
Going to merge this. The only reason for a compiler review is changes to shared code, but they're only test attributes used by tooling tests. |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11235
This PR shares all document and range formatting tests between cohosting and the existing LSP server tests. It also correctly represents the actual test coverage of the LSP server tests by splitting out line ending and fuse into test cases. This means cohost goes from 4 test cases to 540. Not a bad increase.
Commit-at-a-time tells the story, but honestly, if you can ignore the moves of all of the tests (which are purely mechanical I promise) it's probably easier not to bother.
Language server tests look like this:
Cohosting tests can look as awesome as this:
