Merge release/dev17.10 to main #10202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 17.10p1, the FallbackProjectManager would apply changes to the project snapshot manager without scheduling the updates on the dispatcher. This had the potential to create correctness and reliability problems if those changes collided with other updates that *were* scheduled on the dispatcher. To address the correctness problem, I made the FallbackProjectManager async and awaited any updates to the project snapshot manager. However, this created re-entrancy problems that resulted in deadlocks with Roslyn. I fixed a couple of those re-entrancy problems in 17.10p2, but hangs have persisted. A recent Watson dump revealed another yet another re-entrancy issue with background document promotion in the IRazorDynamicFileInfoProvider. The hang occurs when waiting for the FallbackProjectManager to add the file, which causes the project snapshot manager to notify listeners of the update, which causes one of the listener to try and perform the background document promotion again, which causes the hang. To address this, I've decided to just "fire-and-forget" the updates to the project snapshot manager. The updates will still happen on the dispatcher, but we won't wait for them and shouldn't hang.
Back in 17.10p1, the FallbackProjectManager would apply changes to the project snapshot manager without scheduling the updates on the dispatcher. This had the potential to create correctness and reliability problems if those changes collided with other updates that *were* scheduled on the dispatcher. To address the correctness problem, I made the FallbackProjectManager async and awaited any updates to the project snapshot manager. However, this created re-entrancy problems that resulted in deadlocks with Roslyn. I fixed a couple of those re-entrancy problems in 17.10p2, but hangs have persisted. A recent Watson dump revealed another yet another re-entrancy issue with background document promotion in the IRazorDynamicFileInfoProvider. The hang occurs when waiting for the FallbackProjectManager to add the file, which causes the project snapshot manager to notify listeners of the update, which causes one of the listener to try and perform the background document promotion again, which causes the hang. To address this, I've decided to just "fire-and-forget" the updates to the project snapshot manager. The updates will still happen on the dispatcher, but we won't wait for them and shouldn't hang.
dotnet-bot
added
area-infrastructure
auto-merge
DustinCampbell
approved these changes
Apr 2, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from release/dev17.10 into main.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/release/dev17.10-to-main git reset --hard upstream/main git merge upstream/release/dev17.10 # Fix merge conflicts git commit git push upstream merges/release/dev17.10-to-main --force