Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak RazorConfigurationFormatter to account for serialization format change #10157

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Tweak RazorConfigurationFormatter to account for serialization format change #10157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...zor.ProjectEngineHost/Serialization/MessagePack/Formatters/RazorConfigurationFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,21 @@ private RazorConfigurationFormatter()

public override RazorConfiguration Deserialize(ref MessagePackReader reader, SerializerCachingOptions options)
{
// The count is the number of values (2 or 3, depending on what was written) + the number of extensions
var count = reader.ReadArrayHeader();

var configurationName = CachedStringFormatter.Instance.Deserialize(ref reader, options) ?? string.Empty;
var languageVersionText = CachedStringFormatter.Instance.Deserialize(ref reader, options) ?? string.Empty;
var forceRuntimeCodeGeneration = reader.ReadBoolean();

count -= 3;
count -= 2;

var forceRuntimeCodeGeneration = false;

if (reader.NextMessagePackType is MessagePackType.Boolean)
{
forceRuntimeCodeGeneration = reader.ReadBoolean();
count -= 1;
}

using var builder = new PooledArrayBuilder<RazorExtension>();

Expand All @@ -44,7 +52,7 @@ public override RazorConfiguration Deserialize(ref MessagePackReader reader, Ser

public override void Serialize(ref MessagePackWriter writer, RazorConfiguration value, SerializerCachingOptions options)
{
// Write two values + one value per extension.
// Write 3 values + 1 value per extension.
var extensions = value.Extensions;
var count = extensions.Length + 3;

Expand Down