Bring telemetry back for semantic tokens in cohosting #10121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... but in a way that can be tracked separately from existing LSP semantic tokens requests
DustinCampbell
approved these changes
Mar 18, 2024
...icrosoft.VisualStudio.LanguageServerClient.Razor/Cohost/CohostSemanticTokensRangeEndpoint.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the items in #10103
Part of #9519
Rather than move telemetry down into the service, I decided to leave it in the endpoint, and C# specific service, so we can track separate telemetry from existing LSP, to make it easier to report on. In theory this is unnecessary because we already would know the status of A/B flights in the telemetry data, but that doesn't allow for manually switching the flag. If people feel strongly about not using different properties, I'm fine to change. Perhaps all of our telemetry should automatically log cohosting and fuse status as properties?