Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and ban MEF in LanguageServer project #10102

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

davidwengier
Copy link
Member

Fixes #10099

All of the deleted files here were already being removed/moved in #10097. This was only added to MEF for cohosting, and its definitely not needed any more. Also added in the new banned api files.

@davidwengier davidwengier requested a review from a team as a code owner March 15, 2024 02:37
@davidwengier davidwengier enabled auto-merge March 15, 2024 02:56
@davidwengier davidwengier merged commit 11edeff into main Mar 15, 2024
17 checks passed
@davidwengier davidwengier deleted the RemoveMEFfromLS branch March 15, 2024 02:59
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 15, 2024
@@ -47,7 +47,6 @@
<Asset Type="Microsoft.VisualStudio.Assembly" Path="System.Runtime.CompilerServices.Unsafe.dll" />
<Asset Type="Microsoft.VisualStudio.Assembly" Path="System.Threading.Channels.dll" />
<Asset Type="Microsoft.VisualStudio.Assembly" Path="Microsoft.AspNetCore.Razor.LanguageServer.dll" />
<Asset Type="Microsoft.VisualStudio.MefComponent" Path="Microsoft.AspNetCore.Razor.LanguageServer.dll" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop including Microsoft.AspNetCore.Razor.LanguageServer as a MEF component
4 participants