Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TagHelper attribute name completion at attribute name end #10060

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

alexgav
Copy link
Contributor

@alexgav alexgav commented Mar 10, 2024

Summary of the changes

  • Another case where we need to fixup owner returned by FindInnermostNode (that replaced previously used LocateOnwer) in RazorCompletionContext
  • We were already fixing up cases for start/end element name, but we weren't for attributes
  • Previously LocateOwner always gave us MarkupTextLiteral that was a child of the MarkupTagHelperAttribute, but now we get MarkupTagHelperAttribute itself from FindInnermostNode, so we need to add it to the list of exclusions where we don't need to get a parent of the owner
  • Similar to what was done in Remove LocateOwner from completion scenarios #9455

image

Fixes:
#9728

@alexgav alexgav requested a review from a team as a code owner March 10, 2024 20:29
@alexgav alexgav merged commit 7fa8836 into main Mar 12, 2024
12 checks passed
@alexgav alexgav deleted the dev/alexgav/FixTagHelperAttributeNameCompletion branch March 12, 2024 21:15
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 12, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants