Fix custom localization and packing of satellite assemblies #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes SatelliteDllsProjectOutputGroup when SatelliteDllsProjectOutputGroupOutputIntermediate items already exist so that it doesn't double up and malform SatelliteDllsProjectOutputGroupOutputIntermediate items.
When localization for an app occurs another way (like Microsoft's own LCL tooling) the FinalOutputPath isn't what is calculated here. We can preset it in the Intermediate items, but we need MSBuild to preserve that metadata when it is there.
|
I discovered these bugs when trying to validate the fix for NuGet/Home#5160. |
|
@AndyGerlicher Am I targeting the right branch for a 15.3 release? |
cdmihai
approved these changes
May 11, 2017
AndyGerlicher
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing item type qualifier in Condition
This fixes SatelliteDllsProjectOutputGroup when SatelliteDllsProjectOutputGroupOutputIntermediate items already exist so that it doesn't double up and malform SatelliteDllsProjectOutputGroupOutputIntermediate items.
Preserve FinalOutputPath metadata if preset
When localization for an app occurs another way (like Microsoft's own LCL tooling) the FinalOutputPath isn't what is calculated here. We can preset it in the Intermediate items, but we need MSBuild to preserve that metadata when it is there.