Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OpenTelemetry infrastructure #11255

Merged
merged 66 commits into from
Feb 21, 2025
Merged

Implement OpenTelemetry infrastructure #11255

merged 66 commits into from
Feb 21, 2025

Conversation

JanProvaznik
Copy link
Member

@JanProvaznik JanProvaznik commented Jan 10, 2025 •
edited
Loading

Fixes #10945 #10948

Context

#10560

  • infrastructure part of this

Changes Made

add singleton OpenTelemetryManager

executions in Framework (standalone and managed) trace and collect basic build events with a defined sampling rate.
Sending end of build telemetry comparable to the one sent in sdk.

Testing

Unit tests of the behavior,
monitoring if we get data to the backend
manual tests in experimental insertions

Notes

@dotnet dotnet deleted a comment from azure-pipelines bot Jan 10, 2025
@JanProvaznik JanProvaznik marked this pull request as ready for review January 10, 2025 16:28
@JanProvaznik JanProvaznik requested a review from a team as a code owner January 10, 2025 16:28
YuliiaKovalova
YuliiaKovalova reviewed Jan 13, 2025
View reviewed changes
JanKrivanek
JanKrivanek reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I'm not yet reay to sign off - I need a second detailed look, plus there are some notes I put where I'd want your answers first.

JanKrivanek
JanKrivanek approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

I added couple smaller things for consideration - but none are really blocking

@JanProvaznik JanProvaznik mentioned this pull request Feb 3, 2025
Closed
@JanProvaznik
reformulate release checklist, needs hashing clarification, lock-free…
9e06c72 
… early return in initialize, exception pattern match
This was referenced Feb 3, 2025
Open
Open
@JanProvaznik JanProvaznik merged commit 072c659 into dotnet:main Feb 21, 2025
10 checks passed
@JanKrivanek JanKrivanek mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

@rainersigwald rainersigwald rainersigwald left review comments

@JanKrivanek JanKrivanek JanKrivanek approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prototype sending data via VS OTel collector
5 participants
@JanProvaznik @baronfel @rainersigwald @JanKrivanek @YuliiaKovalova