Fixup Flyout Template Parts #8022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jun 14, 2022
| { | ||
| public partial class SandboxShell : Shell | ||
| { | ||
| public SandboxShell() |
There was a problem hiding this comment.
Nobody worry. This is just adding the file for easier testing purposes. I haven't changed the sandbox to default to shell
rachelkang
reviewed
Jun 22, 2022
...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs
Outdated
Show resolved
Hide resolved
rachelkang
reviewed
Jun 22, 2022
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutRenderer.cs
Show resolved
Hide resolved
rachelkang
reviewed
Jun 22, 2022
src/Controls/tests/DeviceTests/Elements/Shell/ShellTests.Android.cs
Outdated
Show resolved
Hide resolved
…id.cs Co-authored-by: Rachel Kang <rachelkang@microsoft.com>
rachelkang
reviewed
Jun 22, 2022
| @@ -42,5 +42,14 @@ public static void AssertWithMessage(Action assertion, string message) | |||
| Assert.True(false, $"Message: {message} Failure: {e}"); | |||
| } | |||
| } | |||
|
|
|||
| public static void CloseEnough(double expected, double actual, double epsilon = 0.2, string? message = null) | |||
There was a problem hiding this comment.
Why is it that we can't get equal but only "close enough" with the various flyout frame measurements?
There was a problem hiding this comment.
The conversion of our DP values to pixels based on the density of the device and then back to DP will result in some fractional precision loss. A 0.2 epsilon represents less than half a pixel.
rachelkang
approved these changes
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #6061