Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimePicker Handlers #454
TimePicker Handlers #454
Changes from 17 commits
2708928
14137d7
15e1373
0cb12df
9fe3d26
a9b200f
c8660b1
80f034a
f2ea57a
76bb2dd
a12e859
fd88755
5341654
f85e18a
4806c25
ae273ca
627610f
2531455
eb36ce9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some overlap with the Picker? I see some derived types here: https://github.com/dotnet/maui/pull/433/files#diff-df34a6df84bad7762b1ed8a016db8d80eeb0e1c94f25562446e52424f94a196a
Also, there is a PickerManager that might have some things that we may want/need? https://github.com/dotnet/maui/pull/433/files#diff-ba5788b29220792f8b9f67a65077c6b25781a9cfd8b59ef06896671af9b24efe
Should these both be using a shared base type that is a PickerEditText and then each type of picker just ahs a thin wrapper for it?