Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Fix flaky UITests failing sometimes 3 #27277

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

  • VerifyInitialEntryReturnTypeChange. Capture depends on a blinking Entry cursor. Sometimes it happens, sometimes it doesn't. Fixed test, cursor is not captured in the image.

@jsuarezruiz jsuarezruiz added area-testing Unit tests, device tests testing-flakiness labels Jan 22, 2025
@Copilot Copilot bot review requested due to automatic review settings January 22, 2025 12:04
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 22, 2025 12:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/Controls/tests/TestCases.HostApp/Issues/Issue21109.xaml: Language not supported
Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.HostApp/Controls/NoCaretEntry.cs:3

  • Ensure that there are tests covering the behavior of the NoCaretEntry class.
public class NoCaretEntry : Entry
#elif IOS
handler.PlatformView.TintColor = UIKit.UIColor.Clear;
#endif
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot change the Cursor color in WinUI. Intentional design decision and are not planning to change that. microsoft/microsoft-ui-xaml#8207

if (view is NoCaretEntry)
{
#if ANDROID
handler.PlatformView.SetCursorVisible(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOS already have a Platform Specific to set the Entry CursorColor https://learn.microsoft.com/en-us/dotnet/maui/ios/platform-specifics/entry-cursor-color?view=net-maui-9.0. We can create another Platform Specific doing the same on Android.

{
public UITestEntryHandler() : base(EntryHandler.Mapper)
{
Mapper.AppendToMapping(nameof(IUITestEntry.IsCursorVisible), (handler, entry) =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create a Platform Specific for Android and iOS adding this property?

@rmarinho rmarinho merged commit 88499e1 into main Feb 4, 2025
316 checks passed
@rmarinho rmarinho deleted the fix-flaky-uitests-3 branch February 4, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests testing-flakiness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants