Run page's content measurement through handler/native control #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent UIScrollView ContentOffset reset when UILabel requests layout Fixes #1269
Redth
approved these changes
Jul 16, 2021
jsuarezruiz
approved these changes
Jul 16, 2021
Redth
added a commit
that referenced
this pull request
Jul 20, 2021
* A mostly-functioning WASDK ScrollView handler * Forgot to check these in * Add request method to IScrollView * Working implementation of CommandMapper and working WinUI ScrollView scroll requests * Remove Actions from PropertyMapper and into CommandMapper * Ported Android ScrollViewRenderer to handler * De-linqify * iOS ScrollViewHandler * ScrollViewHandler iOS (with ContentSize) * Add device tests for ScrollViewHandlers * Remove defunct tests * Fix NRE * Reinstate IntrinsicContentSize check - the bug this was removed to prevent is fixed by PR #1700. * Fix nullability * Fix whitespace * Whitespace * Whitespace * Yes, I'm being picky about whitespace Co-authored-by: Jonathan Dick <jondick@gmail.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Redth
approved these changes
Jul 20, 2021
This was referenced Jul 22, 2021
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentPage is calling measure on content layouts directly, which prevents them from running the measurement via the native control. In some cases, this prevents internal bookkeeping necessary for the control to properly update/redraw.
This change fixes that issue, and fixes an issue with updates on iOS which can cause a UIScrollView's ContentOffset to reset to zero when updating other controls in the layout.
Fixes #1269.