[xcode11.1] [monotouch-test] Fix UrlProtocolTest after a server we don't control changed its output. Fixes xamarin/maccore#2006. #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed its output. Fixes xamarin/maccore#2006. microsoft.com is doing user agent sniffing, and broke our our test since their output is now different. Switch to example.com instead. Fixes https://github.com/xamarin/maccore/issues/2006.
dalexsoto
approved these changes
Oct 2, 2019
rolfbjarne
approved these changes
Oct 2, 2019
mandel-macaque
approved these changes
Oct 2, 2019
|
Build success |
VincentDondain
pushed a commit
to VincentDondain/xamarin-macios
that referenced
this pull request
Oct 16, 2019
…changed its output. Fixes xamarin/maccore#2006. (dotnet#7156) microsoft.com is doing user agent sniffing, and broke our our test since their output is now different. Switch to example.com instead. Fixes xamarin/maccore#2006.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft.com is doing user agent sniffing, and broke our our test since their
output is now different. Switch to example.com instead.
Fixes https://github.com/xamarin/maccore/issues/2006.
Backport of #7154.
/cc @spouliot @rolfbjarne