Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to mono:2019-06 #6196

Merged
merged 60 commits into from
Jul 16, 2019
Merged

Bump to mono:2019-06 #6196

merged 60 commits into from
Jul 16, 2019

Conversation

directhex
Copy link
Contributor

No description provided.

@directhex directhex requested a review from rolfbjarne as a code owner May 31, 2019 19:04
@directhex directhex added run-all-tests Run all our tests. run-internal-tests If tests should be executed on the internal Jenkins instance. skip-api-comparison Skips API / generator diffs when testing pull requests labels May 31, 2019
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
radical and others added 3 commits June 4, 2019 01:15
@radical @akoeplinger
Use the commonly used casing for MSBuildSDKsPath property
1296849 
Handle "incorrectly" cased msbuild property names

msbuild property names are case insensitive. While generating the custom
app.config, in `SetToolsetProperty(..)` we try to update the property if
it already exists. But the name lookup was case sensitive, thus causing
the lookup to fail, resulting in two entries for the same property name
differing only in case. Eg. `MSBuildSDKsPath` vs `MSBuildSdksPath`.

Fixed to ignore case.

Fixes mono/mono#14765 .
@akoeplinger
Bump mono
5294014
@akoeplinger
REVERT THIS: Add workaround for linker issue in mlaunch build
1d25751 
We need to turn off linking for mlaunch which lives in maccore, using the MSBUILD_VERBOSITY variable is the easiest way to do it.
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@mandel-macaque mandel-macaque added the skip-public-jenkins Completely skip execution in the public Jenkins instance label Jun 6, 2019
@dotnet dotnet deleted a comment from monojenkins Jun 6, 2019
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@rolfbjarne rolfbjarne mentioned this pull request Jul 1, 2019
Closed
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@monojenkins

This comment has been minimized.

Sign in to view
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager

This comment has been minimized.

Sign in to view
@monojenkins

This comment has been minimized.

Sign in to view
@xamarin-release-manager
Copy link
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.321.pkg xamarin.mac-5.15.0.321.pkg
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 5b01a55
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

6 tests failed, 165 tests passed.

Failed tests

  • [NUnit] Mono Mac OS X BCL tests group 2/Mac/Modern: Failed (Test run crashed (exit code: 134).)
  • mscorlib/iOS Unified 32-bits - simulator/Debug: Failed
  • mscorlib/iOS Unified 64-bits - simulator/Debug: Failed
  • mscorlib/tvOS - simulator/Debug: Failed
  • mscorlib/watchOS 32-bits - simulator/Debug: Failed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed

@akoeplinger
Disable two accidentally enabled tests
3cc987c 
They were listed as having the RemoteExecutor issue (which was fixed) but they actually fail for unrelated reasons so disable them again.
@monojenkins
Copy link
Collaborator

Build success
ℹ️ Skipped execution
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'

@xamarin-release-manager
Copy link
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.322.pkg xamarin.mac-5.15.0.322.pkg
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 3cc987c
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

2 tests failed, 169 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed

@mandel-macaque mandel-macaque merged commit a29ae8e into master Jul 16, 2019
@mandel-macaque mandel-macaque deleted the mono-2019-06 branch December 7, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewurm lewurm lewurm left review comments

@spouliot spouliot spouliot left review comments

@akoeplinger akoeplinger akoeplinger left review comments

@mandel-macaque mandel-macaque mandel-macaque left review comments

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@chamons chamons Awaiting requested review from chamons

Assignees

@rolfbjarne rolfbjarne

@spouliot spouliot

@akoeplinger akoeplinger

Labels
note-highlight Worth calling out specifically in release notes run-all-tests Run all our tests. run-internal-tests If tests should be executed on the internal Jenkins instance. skip-api-comparison Skips API / generator diffs when testing pull requests skip-public-jenkins Completely skip execution in the public Jenkins instance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@directhex @monojenkins @xamarin-release-manager @spouliot @mandel-macaque @lewurm @rolfbjarne @baulig @akoeplinger @radical