[Rgen] Complete the BindingTypeAttribute analyzer. #21946

mandel-macaque · 2025-01-12T01:21:04Z

The analyzer now checks the following:

All usages of bindingTypeAttribute<T> have to happen on partial classes.
BindingType<Class> can only be used on classes.
BindingType<Category> can only be used on static classes.
BindingType<Protocol> can only be used on interfaces.
BindingType<StrongDictionary> can only be used on classes.
BindingType can only be used on enums.

Because we have not yet released any of the errors, we have sorted them to be the first ones from 0001-0006.

The analyzer now checks the following: * All useages of bindingTypeAttribute<T> have to happen on partial classes. * BidingType<Class> can only be used on classes. * BindingType<Category> can only be used on static classes. * BindingType<Protocol> can only be used on interfaces. * BindingType can onlye be used on enums. Because we have not yet released any of the errors, we have sorted them to be the first ones from 0001-0006.

Copilot

Copilot reviewed 5 out of 10 changed files in this pull request and generated 2 comments.

Files not reviewed (5)

src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.Designer.cs: Language not supported
src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.resx: Language not supported
src/rgen/Microsoft.Macios.Bindings.Analyzer/AnalyzerReleases.Unshipped.md: Evaluated as low risk
src/rgen/Microsoft.Macios.Bindings.Analyzer/BindingTypeSemanticAnalyzer.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Bindings.Analyzer/Extensions/IBindingTypeAnalyzerExtensions.cs: Evaluated as low risk

src/rgen/Microsoft.Macios.Bindings.Analyzer/Extensions/BaseTypeDeclarationSyntaxExtensions.cs

Copilot · 2025-01-12T01:22:51Z

tests/rgen/Microsoft.Macios.Bindings.Analyzer.Tests/BindingTypeSemanticAnalyzerTests.cs

+			yield return [
+				nonPartialClassBinding,
+				BindingTypeSemanticAnalyzer.RBI0001.Id,
+				"The binding type 'Test.Examples' must declared as a partial class"


The error message has a typo: 'The binding type 'Test.Examples' must declared as a partial class' should be 'The binding type 'Test.Examples' must be declared as a partial class'.

Suggested change

"The binding type 'Test.Examples' must declared as a partial class"

"The binding type 'Test.Examples' must be declared as a partial class"

github-actions · 2025-01-12T01:25:05Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2025-01-12T12:13:35Z

/azp run xamarin-macios-pr

…eDeclarationSyntaxExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2025-01-12T12:13:51Z

Azure Pipelines successfully started running 1 pipeline(s).

src/rgen/Microsoft.Macios.Bindings.Analyzer/BindingTypeSemanticAnalyzer.cs

…cAnalyzer.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2025-01-13T12:22:39Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T12:32:07Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T12:47:12Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:05:56Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:06:59Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:07:28Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:08:56Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:10:21Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:11:19Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T16:58:18Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 110 tests passed.

Failures

❌ monotouch tests (macOS)

1 tests failed, 12 tests passed.

monotouch-test/Mac Catalyst/Debug (ARM64): BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2c7759a22dd1073deadecfa55f9587a77d219548 [PR build]

mandel-macaque requested a review from Copilot January 12, 2025 01:21

Copilot AI reviewed Jan 12, 2025

View reviewed changes

Auto-format source code

53cbe4a

This comment has been minimized.

Sign in to view

Update src/rgen/Microsoft.Macios.Bindings.Analyzer/Extensions/BaseTyp…

4d358e8

…eDeclarationSyntaxExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix small typo found by copilot.

2f94826

This comment has been minimized.

Sign in to view

rolfbjarne changed the title ~~[Rgen] Complete the BintingTypeAttribute analyzer.~~ [Rgen] Complete the BindingTypeAttribute analyzer. Jan 13, 2025

rolfbjarne approved these changes Jan 13, 2025

View reviewed changes

src/rgen/Microsoft.Macios.Bindings.Analyzer/BindingTypeSemanticAnalyzer.cs Outdated Show resolved Hide resolved

Update src/rgen/Microsoft.Macios.Bindings.Analyzer/BindingTypeSemanti…

4cc76dd

…cAnalyzer.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

mandel-macaque merged commit 2c7759a into main Jan 13, 2025
6 checks passed

mandel-macaque deleted the dev/mandel/binding-analyzer-binding-types branch January 13, 2025 10:48

	"The binding type 'Test.Examples' must declared as a partial class"
	"The binding type 'Test.Examples' must be declared as a partial class"

[Rgen] Complete the BindingTypeAttribute analyzer. #21946

[Rgen] Complete the BindingTypeAttribute analyzer. #21946

Conversation

mandel-macaque commented Jan 12, 2025 • edited by rolfbjarne Loading

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Jan 12, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Jan 12, 2025

azure-pipelines bot commented Jan 12, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests (macOS)

Successes

mandel-macaque commented Jan 12, 2025 •

edited by rolfbjarne

Loading