[dotnet] Hardcode 'true' as the default value for GenerateSatelliteAssembliesForCore. Fixes #16193.

[rolfbjarne]

Hardcode 'true' as the default value for GenerateSatelliteAssembliesForCore,
because .NET gets it wrong when building from inside VS (Windows).

When building using either VSMac or the command line (either from Windows or
Mac), the MSBuildRuntimeType property is set to Core, and as a result, the
default value for GenerateSatelliteAssembliesForCore is true:

<GenerateSatelliteAssembliesForCore Condition=" '$(GenerateSatelliteAssembliesForCore)' == '' and '$(MSBuildRuntimeType)' == 'Core' ">true</GenerateSatelliteAssembliesForCore>

See: https://github.com/dotnet/sdk/blob/00100960bf06cb595daba647673cd0329be896f4/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L41

This is the correct behavior.

However, when building from inside Visual Studio (for Windows), the
MSBuildRuntimeType property is set to Full, and thus
GenerateSatelliteAssembliesForCore is not set to true, and we end up
executing al.exe to generate satellite assemblies, which is wrong (al.exe
complains that 'arm64' is an invalid platform).

Fix this by always defaulting GenerateSatelliteAssembliesForCore to true,
independent on where we're executing.

Ref: dotnet/sdk#28419.

Fixes #16193.

[vs-mobiletools-engineering-service2]

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Detect API changes'

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: 7ee68aae65c372d5da6450df26a0756be7f0eb06 [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.535-ci.pr.gh16306.pkg
• Microsoft.iOS.Ref.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Sdk.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Templates.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.535-ci.pr.gh16306.pkg
• Microsoft.MacCatalyst.Ref.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.MacCatalyst.Templates.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.macOS.Bundle.12.3.535-ci.pr.gh16306.pkg
• Microsoft.macOS.Ref.12.3.535-ci.pr.gh16306.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.535-ci.pr.gh16306.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.535-ci.pr.gh16306.nupkg
• Microsoft.macOS.Sdk.12.3.535-ci.pr.gh16306.nupkg
• Microsoft.macOS.Templates.12.3.535-ci.pr.gh16306.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-6.0.400.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.400.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-6.0.400.12.3.535-ci.pr.gh16306.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-6.0.400.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.NET.Workload.iOS.15.4.535-ci.pr.gh16306.msi
• Microsoft.tvOS.Bundle.15.4.535-ci.pr.gh16306.pkg
• Microsoft.tvOS.Ref.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.tvOS.Sdk.15.4.535-ci.pr.gh16306.nupkg
• Microsoft.tvOS.Templates.15.4.535-ci.pr.gh16306.nupkg
• xamarin.ios-15.13.0.231.pkg
• xamarin.mac-8.13.0.231.pkg

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: 7ee68aae65c372d5da6450df26a0756be7f0eb06 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 7ee68aae65c372d5da6450df26a0756be7f0eb06 [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]