Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0.1xx-rc2] [msbuild] Make DetectSigningIdentity.CodesignEntitlements an ITaskItem property. #16177

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[release/7.0.1xx-rc2] [msbuild] Make DetectSigningIdentity.CodesignEntitlements an ITaskItem property. #16177

merged 1 commit into from
Sep 28, 2022

Conversation

vs-mobiletools-engineering-service2
Copy link
Collaborator

This way XVS will copy the corresponding file to the mac during a build.

Fixes this error:

Target Name=_DetectSigningIdentity Project=C:\Users\admin\source\repos\iOSApp4\iOSApp4\iOSApp4.csproj
    DetectSigningIdentity
        Assembly = C:\Program Files\dotnet\packs\Microsoft.iOS.Sdk\16.0.515\tools\msbuild\iOS\..\iOS\Xamarin.iOS.Tasks.dll
        Parameters
            AppBundleName = iOSApp4
            BundleIdentifier = com.companyname.iOSApp4
            CodesignEntitlements = Entitlements.plist
            RequireCodeSigning = False
            SdkIsSimulator = True
            SdkPlatform = iPhoneSimulator
            SessionId = ...
            TargetFrameworkMoniker = .NETCoreApp,Version=v6.0,Profile=ios
        DetectSigningIdentity: 2022-09-28T04:17:13.3947732-07:00 - Started
        DetectSigningIdentity: 2022-09-28T04:17:13.3947732-07:00 - Initializing
        [xma][info]: Trying to get a Build Connection for Session '...': Xamarin.Messaging.Build.Client.BuildConnection...., Lifetime: AppDomain
        DetectSigningIdentity: 2022-09-28T04:17:13.3947732-07:00 - Initialized
        DetectSigningIdentity: 2022-09-28T04:17:13.3957722-07:00 - There's no available inputs to copy to the Mac
        DetectSigningIdentity: 2022-09-28T04:17:13.3957722-07:00 - Serializing intputs
        DetectSigningIdentity: 2022-09-28T04:17:13.4077719-07:00 - Executing
        [xma][info]: Starting remote task execution for 'iOSApp4': Xamarin.MacDev.Tasks.DetectSigningIdentity
        [xma][info]: Sending Request Xamarin.Messaging.Build.Contracts.ExecuteTaskMessage to topic xvs/build/execute-task/iOSApp4/01e0050002fDetectSigningIdentity
        [xma][err]: An error occurred on the receiver while executing a post for topic xvs/build/execute-task/iOSApp4/01e0050002fDetectSigningIdentity and client build01e0050ee064bdc5af5fe8d051898268699b25ed1eeec849023e711753e8d82d6484admin
        [xma][info]: An error occurred while executing the operation. The Build Server connection is active and running so no retries will be attempted.
        Errors
            C:\Program Files\dotnet\packs\Microsoft.iOS.Sdk\16.0.515\tools\msbuild\iOS\Xamarin.Shared.targets(1699,3): MessagingRemoteException: An error occurred on client Build while executing a reply for topic xvs/build/execute-task/iOSApp4/01e0050002fDetectSigningIdentity
FileNotFoundException: Could not find file "/Users/vstester/Library/Caches/Xamarin/mtbs/builds/iOSApp4/.../Entitlements.plist"
 [C:\Users\admin\source\repos\iOSApp4\iOSApp4\iOSApp4.csproj]
        DetectSigningIdentity: 2022-09-28T04:17:13.4631033-07:00 - Finished

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1635214.

Backport of #16174

@rolfbjarne
[msbuild] Make DetectSigningIdentity.CodesignEntitlements an ITaskIte…
b732790 
…m property.

This way XVS will copy the corresponding file to the mac during a build.

Fixes this error:

    Target Name=_DetectSigningIdentity Project=C:\Users\admin\source\repos\iOSApp4\iOSApp4\iOSApp4.csproj
        DetectSigningIdentity
            Assembly = C:\Program Files\dotnet\packs\Microsoft.iOS.Sdk\16.0.515\tools\msbuild\iOS\..\iOS\Xamarin.iOS.Tasks.dll
            Parameters
                AppBundleName = iOSApp4
                BundleIdentifier = com.companyname.iOSApp4
                CodesignEntitlements = Entitlements.plist
                RequireCodeSigning = False
                SdkIsSimulator = True
                SdkPlatform = iPhoneSimulator
                SessionId = ...
                TargetFrameworkMoniker = .NETCoreApp,Version=v6.0,Profile=ios
            DetectSigningIdentity: 2022-09-28T04:17:13.3947732-07:00 - Started
            DetectSigningIdentity: 2022-09-28T04:17:13.3947732-07:00 - Initializing
            [xma][info]: Trying to get a Build Connection for Session '...': Xamarin.Messaging.Build.Client.BuildConnection...., Lifetime: AppDomain
            DetectSigningIdentity: 2022-09-28T04:17:13.3947732-07:00 - Initialized
            DetectSigningIdentity: 2022-09-28T04:17:13.3957722-07:00 - There's no available inputs to copy to the Mac
            DetectSigningIdentity: 2022-09-28T04:17:13.3957722-07:00 - Serializing intputs
            DetectSigningIdentity: 2022-09-28T04:17:13.4077719-07:00 - Executing
            [xma][info]: Starting remote task execution for 'iOSApp4': Xamarin.MacDev.Tasks.DetectSigningIdentity
            [xma][info]: Sending Request Xamarin.Messaging.Build.Contracts.ExecuteTaskMessage to topic xvs/build/execute-task/iOSApp4/01e0050002fDetectSigningIdentity
            [xma][err]: An error occurred on the receiver while executing a post for topic xvs/build/execute-task/iOSApp4/01e0050002fDetectSigningIdentity and client build01e0050ee064bdc5af5fe8d051898268699b25ed1eeec849023e711753e8d82d6484admin
            [xma][info]: An error occurred while executing the operation. The Build Server connection is active and running so no retries will be attempted.
            Errors
                C:\Program Files\dotnet\packs\Microsoft.iOS.Sdk\16.0.515\tools\msbuild\iOS\Xamarin.Shared.targets(1699,3): MessagingRemoteException: An error occurred on client Build while executing a reply for topic xvs/build/execute-task/iOSApp4/01e0050002fDetectSigningIdentity
    FileNotFoundException: Could not find file "/Users/vstester/Library/Caches/Xamarin/mtbs/builds/iOSApp4/.../Entitlements.plist"
     [C:\Users\admin\source\repos\iOSApp4\iOSApp4\iOSApp4.csproj]
            DetectSigningIdentity: 2022-09-28T04:17:13.4631033-07:00 - Finished

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1635214.
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: b73279094c2f991b01d4f0a6f615e11f25b3da4d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-007.Monterey
Hash: b73279094c2f991b01d4f0a6f615e11f25b3da4d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests

Pipeline on Agent
Hash: b73279094c2f991b01d4f0a6f615e11f25b3da4d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: b73279094c2f991b01d4f0a6f615e11f25b3da4d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@dalexsoto dalexsoto merged commit 90f75bc into dotnet:release/7.0.1xx-rc2 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

Assignees
No one assigned
Labels
backported not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @chamons @rolfbjarne