[nnyeah] Start testing #14913
[nnyeah] Start testing #14913
Conversation
stephen-hawley
added
enhancement
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| if (output is null) | ||
| output = new StringBuilder (); | ||
|
|
||
| if (env != null) { |
There was a problem hiding this comment.
Lets be consistent
| if (env != null) { | |
| if (env is not null) { |
| if (callingMethod is null) | ||
| Assert.Fail ("unable to get calling test from stack frame."); |
There was a problem hiding this comment.
We can do:
| if (callingMethod is null) | |
| Assert.Fail ("unable to get calling test from stack frame."); | |
| Assert.NotNull (callingMethod, "unable to get calling test from stack frame.); |
There was a problem hiding this comment.
We could even ut an is and remove all those ! everywhere
| public static void TestAndExecute (string libraryCode, string callingCode, string expectedOutput, | ||
| string callingMethodName = "") | ||
| { | ||
| var testName = GetInvokingTestName (out var nameSpace, callingMethodName); |
There was a problem hiding this comment.
I assume that's for use later, this method is not finished.
| string callingMethodName = "") | ||
| { | ||
| var testName = GetInvokingTestName (out var nameSpace, callingMethodName); | ||
| var testClassName = "NnyeahTest" + testName; |
| using var initialLibraryDir = new DisposableTempDirectory (); | ||
| using var finalLibraryDir = new DisposableTempDirectory (); | ||
|
|
||
| var libCompilerOutput = BuildLibrary (libraryCode, testName, initialLibraryDir.DirectoryPath); |
| return callingMethodName; | ||
| } | ||
|
|
||
| public static void TestAndExecute (string libraryCode, string callingCode, string expectedOutput, |
There was a problem hiding this comment.
callingCode and expectedOutput are not used.
There was a problem hiding this comment.
Ditto. I'm just going to leave these ununsed bits in case we wire in test execution.
This comment has been minimized.
This comment has been minimized.
| @@ -4,6 +4,8 @@ | |||
| using System.Runtime.InteropServices; | |||
| using System.Threading; | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
I'll take care of this in a diff PR.
There was a problem hiding this comment.
| @@ -16,6 +16,8 @@ | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
I'll take care of this in a diff PR.
| @@ -3,6 +3,8 @@ | |||
| using System.Linq; | |||
| using System.Text; | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
I'll take care of this in a diff PR.
| { | ||
| var compilerArgs = BuildCompilerArgs (sourceFiles, outputFile, platformName, isLibrary); | ||
| Execution execution = await Execution.RunAsync(MonoCompiler, compilerArgs, mergeOutput: true, workingDirectory: workingDirectory); | ||
| return execution!.StandardOutput.ToString()!; |
There was a problem hiding this comment.
I'll fix this need of ! in a follow up PR.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1096.Monterey |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌Failed tests are:
Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
|
Failures are unrelated and they are network based. |
Added code to:
Added a single unit test of the smoke test variety.
This code is currently missing the process of running nnyeah on the output and compiling and running a .NET app and collecting the output.