[Xtro] Fix xtro runs for classic when performed in a bot that did not build #14504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamons
approved these changes
Mar 25, 2022
| @@ -191,10 +191,10 @@ endif | |||
| gen-all: gen-ios gen-tvos gen-watchos gen-macos | |||
|
|
|||
| wrench: | |||
| $(MAKE) -j8 classify | |||
| $(MAKE) -j8 classify V=1 | |||
There was a problem hiding this comment.
Do we still want this bit?
There was a problem hiding this comment.
I want it to see what is going on, might be too verbose locally
dalexsoto
approved these changes
Mar 25, 2022
rolfbjarne
requested changes
Mar 28, 2022
There was a problem hiding this comment.
I've updated with the tip of main, because 1e8e4bb might have fixed the hangs.
tests/xtro-sharpie/Makefile
Outdated
| @@ -37,7 +37,7 @@ bin/Debug/xtro-sharpie.exe xtro-report/bin/Debug/xtro-report.exe xtro-sanity/bin | |||
| $(Q) touch $@ | |||
|
|
|||
| ifdef TESTS_USE_SYSTEM | |||
| XIOS ?= /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/iOS/Xamarin.iOS.dll | |||
| XIOS ?= /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/Xamarin.iOS.dll | |||
There was a problem hiding this comment.
This is not correct, this file does not exist on my system:
$ ls -la /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits
total 0
drwxr-xr-x 5 rolf staff 160 Jan 17 03:18 .
drwxr-xr-x 9 rolf staff 288 Jan 17 03:20 ..
drwxr-xr-x 4 rolf staff 128 Mar 28 09:18 iOS
drwxr-xr-x 4 rolf staff 128 Mar 28 09:18 tvOS
drwxr-xr-x 4 rolf staff 128 Mar 28 09:18 watchOS
tests/xtro-sharpie/Makefile
Outdated
Comment on lines
228
to
232
| STAMP_CLASSIFY_IOS_DEPS := bin/Debug/xtro-sharpie.exe $(XIOS_PCH) | ||
| ifndef TESTS_USE_SYSTEM | ||
| STAMP_CLASSIFY_IOS_DEPS += $(XIOS) | ||
| STAMP_CLASSIFY_IOS_DEPS += $(XIOS_GL) | ||
| endif |
There was a problem hiding this comment.
The reason you had to do this change was because the dll doesn't exist... but that doesn't make things work, it just makes xtro not run correctly.
rolfbjarne
added
skip-all-tests
|
xtro (legacy) succeeded on the last completed main build: ee302b1#commitcomment-69857175, so this doesn't seem necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes: