Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET Attribute Conversion] Rerun with fixes to catch old/unlisted availability and type information. Enable one test. #14287

Closed
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
08619d0
[NET Attribute Conversion] Chip Framework
chamons Feb 11, 2022
d9acdf1
[NET Attribute Conversion] Rerun with many fixes
chamons Feb 11, 2022
5d06b66
Code reivew improvements
chamons Mar 1, 2022
b7b6329
Revert unnecessary ignores
chamons Mar 2, 2022
5c3786b
Remove all attributes on partial classes in code behind
chamons Mar 2, 2022
b23cbb4
Add enum todo's as generator work is not complete
chamons Mar 2, 2022
a47fc13
[generator] Fix crash when referencing types that have introduced wit…
chamons Mar 2, 2022
0ba56ed
[Introspection] Improve error message in case to include type
chamons Mar 3, 2022
ef02857
Disable availabile & unavailable check in NET as its required there
chamons Mar 3, 2022
baae3c1
[Introspection] Add disables until generator work is in
chamons Mar 3, 2022
c305405
More code reivew changes
chamons Mar 3, 2022
8f02430
Remove a few more unneeded attributes
chamons Mar 3, 2022
353b9fc
Code review changes
chamons Mar 7, 2022
1bd9713
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 7, 2022
81057e7
Fix test failures
chamons Mar 7, 2022
2e6e1b6
Remove unnecessary attributes on public partial
chamons Mar 8, 2022
eba0ec5
Clear up some incorrect supported on types mel mis-guessed on
chamons Mar 8, 2022
bf5b19d
Add new cecil test to detect double attributed elements and fix a lar…
chamons Mar 8, 2022
f1b8e9b
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 10, 2022
fc3e428
Update src/generator-attribute-manager.cs
chamons Mar 10, 2022
32658fa
Code review changes
chamons Mar 10, 2022
669494c
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 10, 2022
bd872e5
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 11, 2022
f32651c
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 11, 2022
1c36da1
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
mandel-macaque Mar 12, 2022
92e446d
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 14, 2022
7c3f397
Merge branch 'main' into attribute_super_convert_type_mass_smash_2
chamons Mar 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAssetDownloadTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,16 @@

using System;
using Foundation;
using System.Runtime.Versioning;

namespace AVFoundation {
#if !MONOMAC && !WATCH && !TVOS
#if NET
[SupportedOSPlatform ("ios9.0")]
[SupportedOSPlatform ("macos12.0")]
[SupportedOSPlatform ("maccatalyst")]
[UnsupportedOSPlatform ("tvos")]
#endif
public partial class AVAssetDownloadTask : NSUrlSessionTask {

// NSURLRequest and NSURLResponse objects are not available for AVAssetDownloadTask
Expand Down
8 changes: 8 additions & 0 deletions src/AVFoundation/AVAssetDownloadUrlSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,17 @@
using System;
using Foundation;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace AVFoundation {

#if !MONOMAC
#if NET
[SupportedOSPlatform ("ios9.0")]
[SupportedOSPlatform ("macos12.0")]
[SupportedOSPlatform ("maccatalyst")]
[UnsupportedOSPlatform ("tvos")]
#endif
public partial class AVAssetDownloadUrlSession : NSUrlSession {

public new static NSUrlSession SharedSession {
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAssetResourceLoadingDataRequest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,15 @@

using System;
using Foundation;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios7.0")]
[SupportedOSPlatform ("macos10.9")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVAssetResourceLoadingDataRequest {
public override string ToString ()
{
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAudioBuffer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,15 @@
using Foundation;
using System;
using AudioToolbox;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios8.0")]
[SupportedOSPlatform ("macos10.10")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVAudioBuffer {
public AudioBuffers AudioBufferList {
get {
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAudioChannelLayout.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,15 @@
using System.ComponentModel;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios8.0")]
[SupportedOSPlatform ("macos10.10")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVAudioChannelLayout {
static IntPtr CreateLayoutPtr (AudioChannelLayout layout, out IntPtr handleToLayout)
{
Expand Down
2 changes: 2 additions & 0 deletions src/AVFoundation/AVAudioConverterPrimeInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios9.0")]
[SupportedOSPlatform ("macos10.11")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#else
[iOS (9,0)]
[Mac (10,11)]
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAudioFormat.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,15 @@
using System;
using System.ComponentModel;
using System.Runtime.CompilerServices;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios8.0")]
[SupportedOSPlatform ("macos10.10")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVAudioFormat {
public static bool operator == (AVAudioFormat a, AVAudioFormat b)
{
Expand Down
8 changes: 8 additions & 0 deletions src/AVFoundation/AVAudioPlayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,17 @@
using ObjCRuntime;
using AudioToolbox;
using System;
using System.Runtime.Versioning;

namespace AVFoundation {

#if !WATCH
#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVAudioPlayer {

public static AVAudioPlayer FromUrl (NSUrl url, out NSError error)
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAudioRecorder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@

namespace AVFoundation {
#if !TVOS
#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[UnsupportedOSPlatform ("tvos")]
#endif
public partial class AVAudioRecorder {
AVAudioRecorder (NSUrl url, AudioSettings settings, out NSError error) {
// We use this method because it allows us to out NSError but, as a side effect, it is possible for the handle to be null and we will need to check this manually (on the Create method).
Expand Down Expand Up @@ -63,6 +69,7 @@ public static AVAudioRecorder Create (NSUrl url, AudioSettings settings, out NSE
#if NET
[SupportedOSPlatform ("ios10.0")]
[SupportedOSPlatform ("macos10.12")]
[SupportedOSPlatform ("maccatalyst")]
[UnsupportedOSPlatform ("tvos")]
#else
[iOS (10,0)]
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVAudioSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
using System;
using System.ComponentModel;
using System.Runtime.CompilerServices;
using System.Runtime.Versioning;

namespace AVFoundation {

Expand All @@ -41,6 +42,12 @@ public enum AVAudioSessionCategory {
MultiRoute
}

#if NET
[SupportedOSPlatform ("macos11.0")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVAudioSession : NSObject {
public NSError SetActive (bool beActive)
{
Expand Down
16 changes: 16 additions & 0 deletions src/AVFoundation/AVAudioSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@

namespace AVFoundation {


#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
// Should be called AVAudioSetting but AVAudioSetting has been already used by keys class
public class AudioSettings : DictionaryContainer
{
Expand Down Expand Up @@ -165,6 +172,9 @@ public int? EncoderBitDepthHint {

#if NET
[SupportedOSPlatform ("ios7.0")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#else
[iOS (7,0)]
#endif
Expand Down Expand Up @@ -207,6 +217,9 @@ public AVAudioBitRateStrategy? BitRateStrategy {

#if NET
[SupportedOSPlatform ("ios7.0")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#else
[iOS (7,0)]
#endif
Expand Down Expand Up @@ -239,6 +252,9 @@ public AVSampleRateConverterAlgorithm? SampleRateConverterAlgorithm {

#if NET
[SupportedOSPlatform ("ios7.0")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#else
[iOS (7,0)]
#endif
Expand Down
2 changes: 2 additions & 0 deletions src/AVFoundation/AVBeatRange.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios9.0")]
[SupportedOSPlatform ("macos10.11")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#else
[iOS (9,0)]
[Mac (10,11)]
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVCaptureDeviceInput.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,15 @@
using System;
using Foundation;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("maccatalyst14.0")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("macos")]
[UnsupportedOSPlatform ("tvos")]
#endif
public partial class AVCaptureDeviceInput {
static public AVCaptureDeviceInput FromDevice (AVCaptureDevice device)
{
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVCaptureFileOutput.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,15 @@
using System;
using Foundation;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("maccatalyst14.0")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("macos")]
[UnsupportedOSPlatform ("tvos")]
#endif
public partial class AVCaptureFileOutput {
class recordingProxy : AVCaptureFileOutputRecordingDelegate {
Action<NSObject []> startRecordingFromConnections;
Expand Down
6 changes: 6 additions & 0 deletions src/AVFoundation/AVCaptureVideoPreviewLayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("maccatalyst14.0")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("macos")]
[UnsupportedOSPlatform ("tvos")]
#endif
public partial class AVCaptureVideoPreviewLayer {

public enum InitMode {
Expand Down
6 changes: 6 additions & 0 deletions src/AVFoundation/AVContentKeyResponse.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
namespace AVFoundation {

#if !WATCH
#if NET
[SupportedOSPlatform ("tvos10.2")]
[SupportedOSPlatform ("macos10.12.4")]
[SupportedOSPlatform ("ios10.3")]
[SupportedOSPlatform ("maccatalyst")]
#endif
public partial class AVContentKeyResponse {

public static AVContentKeyResponse Create (NSData fairPlayStreamingKeyResponseData) => Create (fairPlayStreamingKeyResponseData, AVContentKeyResponseDataType.FairPlayStreamingKeyResponseData);
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVDepthData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,15 @@
using ObjCRuntime;
using CoreVideo;
using ImageIO;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("maccatalyst14.0")]
[SupportedOSPlatform ("tvos11.0")]
[SupportedOSPlatform ("ios11.0")]
[SupportedOSPlatform ("macos10.13")]
#endif
public partial class AVDepthData {

public static AVDepthData Create (CGImageAuxiliaryDataInfo dataInfo, out NSError error)
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVEdgeWidths.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,16 @@
using System.Runtime.InteropServices;
using Foundation;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace AVFoundation {

#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
[StructLayout (LayoutKind.Sequential)]
public struct AVEdgeWidths {
public nfloat /* CGFloat */ Left, Top, Right, Bottom;
Expand Down
19 changes: 19 additions & 0 deletions src/AVFoundation/AVLayerVideoGravity.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
using Foundation;
using CoreFoundation;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace AVFoundation {
// Convenience enum for native strings - AVAnimation.h
Expand All @@ -42,6 +43,12 @@ public enum AVLayerVideoGravity
Resize
}

#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
partial class AVPlayerLayer
{
static internal AVLayerVideoGravity KeyToEnum (NSString key, bool clamp = true)
Expand Down Expand Up @@ -85,6 +92,12 @@ public AVLayerVideoGravity VideoGravity
}

#if !TVOS
#if NET
[SupportedOSPlatform ("maccatalyst14.0")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("macos")]
[UnsupportedOSPlatform ("tvos")]
#endif
partial class AVCaptureVideoPreviewLayer
{
// Should be VideoGravity only but previous binding was wrong
Expand All @@ -100,6 +113,12 @@ public AVLayerVideoGravity VideoGravity
}
#endif

#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
partial class AVPlayer
{
public AVLayerVideoGravity? ExternalPlaybackVideoGravity {
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVPixelAspectRatio.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,16 @@
using System.Runtime.InteropServices;
using Foundation;
using ObjCRuntime;
using System.Runtime.Versioning;

namespace AVFoundation {

#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
[StructLayout (LayoutKind.Sequential)]
public struct AVPixelAspectRatio {
public nint /* NSInteger */ HorizontalSpacing;
Expand Down
7 changes: 7 additions & 0 deletions src/AVFoundation/AVPlayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,15 @@
using Foundation;
using CoreMedia;
using CoreVideo;
using System.Runtime.Versioning;

namespace AVFoundation {
#if NET
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
#endif
public partial class AVPlayerItemVideoOutput {
public CVPixelBuffer CopyPixelBuffer (CMTime itemTime, ref CMTime outItemTimeForDisplay)
{
Expand Down
Loading