[tests] Add disabled NET6 availability attribute test #14106

chamons · 2022-02-08T17:45:04Z

This test is double disabled:

Completely disabled until mellite is re-run with a hacked platform assembly and default platform assembly
Once that's fixed, I'll enable the test, but it'll still be disabled on generated code (via HasCodegenAttribute) until the generator is also fixed.

But I wanted to get it in and reviewed sooner.

chamons · 2022-02-08T17:48:08Z

A lot of the duplication in functions at the bottom is due to the fact that CustomAttributes is not on any Cecil base class from what I could tell, so I had to abuse type overloading to share code.

mandel-macaque

Looks good, not blocking for my nits, please clean them a little :)

tests/cecil-tests/AttributeTest.cs

mandel-macaque · 2022-02-08T18:20:30Z

tests/cecil-tests/AttributeTest.cs

+// #if DEBUG
+// 			const string Filter = "AppKit";
+// 			if (!fullName.Contains (" " + Filter)) {
+// 				return;
+// 			}
+// #endif


remote it? or uncomment?

I think this is fine to keep until we are done with the test in general

I'm planning on landing these just to uncomment out when debugging the mel and generator changes.

mandel-macaque · 2022-02-08T18:20:38Z

tests/cecil-tests/AttributeTest.cs

+// 			// iOS implies maccatalyst, but only for parent scope
+// 			if (parentAvailability.Contains("ios") && !parentAvailability.Contains("maccatalyst")) {
+// 				parentAvailability.Append("maccatalyst");
+// 			}


same as above

tests/cecil-tests/AttributeTest.cs

vs-mobiletools-engineering-service2 · 2022-02-09T02:15:31Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 105 tests passed.

Failed tests

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2579 Inconclusive: 11 Failed: 1 Ignored: 192)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge cf7eff1 into 4a7bd98

tests/cecil-tests/AttributeTest.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

chamons · 2022-02-09T16:13:44Z

Added that second suggested test.

tj-devel709 · 2022-02-09T17:40:24Z

tests/cecil-tests/AttributeTest.cs

+			if (attribute.ConstructorArguments.Count == 1 && attribute.ConstructorArguments[0].Type.Name == "String") {
+				string full = (string)attribute.ConstructorArguments[0].Value;
+				switch (full) {
+					case string s when full.StartsWith("ios", StringComparison.Ordinal):


Woah, I've never seen this before! Very handy

tests/cecil-tests/AttributeTest.cs

…ios into attribute_cecil_test

vs-mobiletools-engineering-service2 · 2022-02-09T22:59:14Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 105 tests passed.

Failed tests

trimmode link/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1098.BigSur
Merge ee58472 into d5c3f2f

tests/cecil-tests/AttributeTest.cs

rolfbjarne · 2022-02-10T07:40:44Z

tests/cecil-tests/AttributeTest.cs

+		}
+
+		// Unfortunate state we need to keep since I can't see to walk "up" from a
+		// MethodDefinition get_Foo or SetFoo to see it's container's properties


Something like this should work:

var getter = ...; var property = getter.DeclaringType.Properties.Find (v => v.Name == getter.Name.Substring (4));

It seems to work, at least enough for this PR. I'll fix it up with the attribute changes in follow up.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2022-02-11T01:33:20Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 105 tests passed.

Failed tests

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2578 Inconclusive: 11 Failed: 2 Ignored: 192)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 60690ae into 478c1d2

chamons · 2022-02-11T15:10:27Z

Test failure was good old https://github.com/xamarin/maccore/issues/2443

[tests] Add disabled NET6 availability attribute test

f1814bc

chamons requested review from dalexsoto, rolfbjarne, mandel-macaque, stephen-hawley and tj-devel709 February 8, 2022 17:45

Fix spacing issue

d7d4ca9

chamons added the not-notes-worthy Ignore for release notes label Feb 8, 2022

dalexsoto approved these changes Feb 8, 2022

View reviewed changes

mandel-macaque approved these changes Feb 8, 2022

View reviewed changes

chamons added 2 commits February 8, 2022 13:04

Code reivew changes

ac0a6a4

Fix compile issue

cf7eff1

rolfbjarne reviewed Feb 9, 2022

View reviewed changes

chamons and others added 6 commits February 9, 2022 09:05

Apply suggestions from code review

454d5df

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Fix build

e5225eb

More code simplification

6a3967f

More code simplification

5f33013

Add second test

3c53449

Merge branch 'main' into attribute_cecil_test

d89a9d2

tj-devel709 reviewed Feb 9, 2022

View reviewed changes

tests/cecil-tests/AttributeTest.cs Outdated Show resolved Hide resolved

tj-devel709 approved these changes Feb 9, 2022

View reviewed changes

chamons added 3 commits February 9, 2022 12:07

Fix bindingimpl check for property get/set and bunch of formatting

57cc216

Merge branch 'attribute_cecil_test' of github.com:chamons/xamarin-mac…

f815658

…ios into attribute_cecil_test

More formatting

ee58472

rolfbjarne reviewed Feb 10, 2022

View reviewed changes

chamons and others added 4 commits February 10, 2022 14:09

Apply suggestions from code review

2da93af

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Fix code to compile

8b469bd

Apply Rolf's suggestion

afd3f20

Add field test

60690ae

rolfbjarne approved these changes Feb 11, 2022

View reviewed changes

chamons merged commit 39d52ba into dotnet:main Feb 11, 2022

chamons deleted the attribute_cecil_test branch February 11, 2022 15:11

chamons mentioned this pull request Feb 11, 2022

[NET Attribute Conversion] Rerun with fixes to catch old/unlisted availability #14128

Closed

chamons mentioned this pull request Mar 1, 2022

[NET Attribute Conversion] Rerun with fixes to catch old/unlisted availability and type information. Enable one test. #14287

Closed

chamons mentioned this pull request Apr 5, 2022

[NET Attribute Conversion] Add missing attributes in code-behind by re-running conversion #14660

Merged

chamons mentioned this pull request Apr 29, 2022

Add a cecil test to compare [Availability] attributes (legacy) with [SupportedOSPlatform] (net6) #12544

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests] Add disabled NET6 availability attribute test #14106

[tests] Add disabled NET6 availability attribute test #14106

chamons commented Feb 8, 2022

chamons commented Feb 8, 2022

mandel-macaque left a comment

mandel-macaque Feb 8, 2022

dalexsoto Feb 8, 2022

chamons Feb 8, 2022

mandel-macaque Feb 8, 2022

dalexsoto Feb 8, 2022

vs-mobiletools-engineering-service2 commented Feb 9, 2022

Failed tests

chamons commented Feb 9, 2022

tj-devel709 Feb 9, 2022 •

edited

Loading

vs-mobiletools-engineering-service2 commented Feb 9, 2022

Failed tests

rolfbjarne Feb 10, 2022

chamons Feb 10, 2022

vs-mobiletools-engineering-service2 commented Feb 11, 2022

Failed tests

chamons commented Feb 11, 2022

[tests] Add disabled NET6 availability attribute test #14106

[tests] Add disabled NET6 availability attribute test #14106

Conversation

chamons commented Feb 8, 2022

chamons commented Feb 8, 2022

mandel-macaque left a comment

Choose a reason for hiding this comment

mandel-macaque Feb 8, 2022

Choose a reason for hiding this comment

dalexsoto Feb 8, 2022

Choose a reason for hiding this comment

chamons Feb 8, 2022

Choose a reason for hiding this comment

mandel-macaque Feb 8, 2022

Choose a reason for hiding this comment

dalexsoto Feb 8, 2022

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Feb 9, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

chamons commented Feb 9, 2022

tj-devel709 Feb 9, 2022 • edited Loading

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Feb 9, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne Feb 10, 2022

Choose a reason for hiding this comment

chamons Feb 10, 2022

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Feb 11, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

chamons commented Feb 11, 2022

tj-devel709 Feb 9, 2022 •

edited

Loading