Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.1xx-preview5] Update dependencies from dotnet/installer #11873

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 9, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/installer

  • Subscription: edb2abca-4bb6-47fd-e0b8-08d91b0a84f2
  • Build: 20210707.58
  • Date Produced: 7/8/2021 4:14 AM
  • Commit: c5815e6739a30ca995310ca0d32e2dca60d631ba
  • Branch: refs/heads/release/6.0.1xx-preview5

…210608.63

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.5.21308.1 -> To Version 6.0.100-preview.5.21308.63
@spouliot
Copy link
Contributor

spouliot commented Jun 9, 2021

@rolfbjarne
Copy link
Member

Test failures are unrelated

monotouch-test/iOS Unified 32-bits - simulator/Debug: #11504
monotouch-test/iOS Unified 64-bits - simulator/Debug (all optimizations) [dotnet]: https://github.com/xamarin/maccore/issues/2409
introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): https://github.com/xamarin/maccore/issues/2420

@rolfbjarne
Copy link
Member

Not quite sure if we should settle on a P5 version or if we should keep merging these PRs (waiting for a decision).

@spouliot
Copy link
Contributor

Not quite sure if we should settle on a P5 version or if we should keep merging these PRs (waiting for a decision).

c.c. @dalexsoto

If we don't bump

... then no one (e.g. Maui) will be using those changes and we might not know about issue(s) specific to this bump.

If we have to (important fix) bump later, with a new/updated PR, then the issue will be found, only later. That gives us less time to fix the issue (which will likely require yet another bump). Also the change set will be larger making identifying the issue more difficult (or at least not easier).

If we bump

we're still able to go back to a previous commit (un-bump) if needed. E.g. if an issue found or to match the same version as other SDK.

dotnet-maestro bot added 3 commits June 25, 2021 12:26
…210624.5

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.5.21308.1 -> To Version 6.0.100-preview.5.21324.5
…210625.3

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.5.21308.1 -> To Version 6.0.100-preview.5.21325.3
…210707.58

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.5.21308.1 -> To Version 6.0.100-preview.5.21357.58
@rolfbjarne
Copy link
Member

Preview 6 is out, so this is no longer relevant.

@rolfbjarne rolfbjarne closed this Jul 19, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-release/6.0.1xx-preview5-ba4fdd1e-aa12-4b5e-8c4a-9423c04eb1cc branch July 19, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants