Link FrameworkList.xml to a place where MSBuild SDK actually expects it #10928

filipnavara · 2021-03-22T10:17:34Z

The SDK conflict resolution code expects the FrameworkList.xml file to be located in $(TargetFrameworkDirectory)/RedistList/FrameworkList.xml.

Should fix
dotnet/runtime#49211
dotnet/runtime#49940
dotnet/runtime#49477
#10912
#10839
#10548
#10592
mono/mono#20805
mono/mono#20894

rolfbjarne · 2021-03-22T10:34:11Z

/azp run

azure-pipelines · 2021-03-22T10:34:39Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2021-03-22T11:01:00Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent

rolfbjarne · 2021-03-22T11:17:07Z

This is the failure:

ln: /Users/builder/azdo/_work/1/s/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/lib/mono/Xamarin.iOS/RedistList/FrameworkList.xml: No such file or directory
make[1]: *** [/Users/builder/azdo/_work/1/s/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/lib/mono/Xamarin.iOS/RedistList/FrameworkList.xml] Error 1
make[1]: *** Waiting for unfinished jobs....

My guess is that the target directory doesn't exist.

You can probably repro this locally by doing this from the root directory (this will do a clean build):

make git-clean-all
make all -j8

filipnavara · 2021-03-22T11:19:51Z

Thanks. I am doing the local build on clean machine now. I likely didn't notice it because I was testing the steps manually before and I created the directories and links by hand earlier.

spouliot

👍

rolfbjarne · 2021-03-22T13:10:11Z

/azp run

azure-pipelines · 2021-03-22T13:10:39Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2021-03-22T13:10:51Z

I don't think we've had a PR that fixes that many issues before..

filipnavara · 2021-03-22T14:05:40Z

I'd like to at least manually verify the packages once they are built. I also have a build test written locally but I need to fix my Xcode installation first so I can run it.

chamons

🎉

mandel-macaque · 2021-03-22T16:31:27Z

@filipnavara I'll make sure that pkgs are created and will post links here.

mandel-macaque · 2021-03-22T16:34:24Z

@filipnavara FYI: ba7c837

filipnavara · 2021-03-22T16:37:54Z

@mandel-macaque Thanks a lot.

I'm still playing with some trivial test to ensure that everything is working properly:
4af5fd5

mandel-macaque · 2021-03-22T17:21:48Z

@filipnavara do you need that last commit too?

filipnavara · 2021-03-22T17:23:34Z

@mandel-macaque Nah, just the first two.

vs-mobiletools-engineering-service2 · 2021-03-22T20:06:43Z

✅ Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

🎉 All 182 tests passed 🎉

Pipeline on Agent XAMBOT-1103'

filipnavara · 2021-03-23T07:02:48Z

Unfortunately the packaging fails [which I anticipated] by having the symlinks point to wrong location:

filipnavara@172-4-1-17 app % ls -l /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/
total 0
lrwxr-xr-x  1 root  wheel  161 Mar 23 07:57 FrameworkList.xml -> /Users/builder/azdo/_work/1/s/maccore/release/_mac-install/Library/Frameworks/Xamarin.Mac.framework/Versions/7.11.0.225/lib/mono/4.5/RedistList/FrameworkList.xml

I suppose I need to modify it to make the symlink with absolute path.

Is there any way to make the packages locally? Or can you give me pointer on how the other symlinks are handled? I also have an alternative solution without symlinks but I would like to understand the process nevertheless.

rolfbjarne · 2021-03-23T07:45:33Z

Unfortunately the packaging fails [which I anticipated] by having the symlinks point to wrong location:
filipnavara@172-4-1-17 app % ls -l /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/
total 0
lrwxr-xr-x  1 root  wheel  161 Mar 23 07:57 FrameworkList.xml -> /Users/builder/azdo/_work/1/s/maccore/release/_mac-install/Library/Frameworks/Xamarin.Mac.framework/Versions/7.11.0.225/lib/mono/4.5/RedistList/FrameworkList.xml
I suppose I need to modify it to make the symlink with absolute path.

This is handled by using $(IOS_TARGETDIR) instead of $(IOS_DESTDIR): the former is empty when building a package, and the same as IOS_DESTDIR when building locally.

Example:

https://github.com/xamarin/xamarin-macios/blob/b2248993de13ab31d3c66b74820cb3f0077032c6/msbuild/Makefile#L247-L248

Is there any way to make the packages locally? Or can you give me pointer on how the other symlinks are handled? I also have an alternative solution without symlinks but I would like to understand the process nevertheless.

Unfortunately the code to build the package is not public.

filipnavara · 2021-03-23T09:50:09Z

@rolfbjarne Thanks. Makes a lot more sense. Ready for take two on the package build :-)

rolfbjarne · 2021-03-23T09:59:41Z

New build has been scheduled!

rolfbjarne · 2021-03-23T10:53:08Z

Failure:

[...]
[BUILD] mlaunch
/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(84,5): error MSB4184: The expression "[Microsoft.Build.Utilities.ToolLocationHelper]::GetPathToStandardLibraries(Xamarin.Mac, v2.0, '', '', '', /Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Mono.framework/External/xbuild-frameworks;/Library/Frameworks/Mono.framework/External/xbuild-frameworks)" cannot be evaluated. There was an error reading the redist list file "/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/FrameworkList.xml". Could not find file "/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/FrameworkList.xml" [/Users/builder/azdo/_work/1/s/maccore/tools/mlaunch/Xamarin.Hosting/Xamarin.Hosting.csproj]
/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(84,5): error MSB4184: The expression "[Microsoft.Build.Utilities.ToolLocationHelper]::GetPathToStandardLibraries(Xamarin.Mac, v2.0, '', '', '', /Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Mono.framework/External/xbuild-frameworks;/Library/Frameworks/Mono.framework/External/xbuild-frameworks)" cannot be evaluated. There was an error reading the redist list file "/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/FrameworkList.xml". Could not find file "/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/FrameworkList.xml" [/Users/builder/azdo/_work/1/s/maccore/tools/mlaunch/Xamarin.Hosting/Xamarin.Launcher/Xamarin.Launcher.csproj]
/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/Microsoft.Common.CurrentVersion.targets(84,5): error MSB4184: The expression "[Microsoft.Build.Utilities.ToolLocationHelper]::GetPathToStandardLibraries(Xamarin.Mac, v2.0, '', '', '', /Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Mono.framework/External/xbuild-frameworks;/Library/Frameworks/Mono.framework/External/xbuild-frameworks)" cannot be evaluated. There was an error reading the redist list file "/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/FrameworkList.xml". Could not find file "/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/RedistList/FrameworkList.xml" [/Users/builder/azdo/_work/1/s/maccore/tools/mlaunch/Xamarin.Hosting/Xamarin.Localization.Mlaunch/Xamarin.Localization.Mlaunch.csproj]

This is in a private part of our build, so I'll have a look.

filipnavara · 2021-03-23T10:59:45Z

This is in a private part of our build, so I'll have a look.

It's the symlinks pointing to non-existing file. Just fails at that particular point because it's the first task accessing the file through the symlink.

Sorry for the slow turn around, it's quite tricky for me to test these changes locally.

filipnavara · 2021-03-23T19:53:46Z

I manually verified the latest package on my test case so dropping the draft status.

dalexsoto · 2021-03-23T20:29:12Z

We should backport this to xcode12.5 and d16-9 once it is merged

filipnavara · 2021-03-23T20:52:10Z

There's still some Mac Catalyst test failing. I'll try to see if I can reproduce it locally with the packages. If there's any more detailed error message it would be helpful.

dalexsoto · 2021-03-23T21:35:32Z

@filipnavara I think your changes are ok and unrelated to the failure on device tests, the PR tests seems to be fine #10928 (comment) I'll let @rolfbjarne confirm and the merge decision.

rolfbjarne · 2021-03-24T06:46:28Z

The only test result we care about at the moment is this one: #10928 (comment), and that's green.

dalexsoto · 2021-03-24T10:51:03Z

/sudo backport d16-9

dalexsoto · 2021-03-24T10:51:17Z

/sudo backport xcdoe12.5

vs-mobiletools-engineering-service2 · 2021-03-24T10:51:30Z

Backport Job to branch d16-9 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-03-24T10:51:40Z

Backport Job to branch xcdoe12.5 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-03-24T10:52:41Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4587204 for more details.

rolfbjarne · 2021-03-24T11:04:06Z

/sudo backport xcode12.5

vs-mobiletools-engineering-service2 · 2021-03-24T11:04:30Z

Backport Job to branch xcode12.5 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-03-24T11:06:03Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4587227 for more details.

Link FrameworkList.xml to a place where MSBuild SDK actually expects it

0a6879d

rolfbjarne added bug If an issue is a bug or a pull request a bug fix community Community contribution ❤ labels Mar 22, 2021

rolfbjarne added the note-highlight Worth calling out specifically in release notes label Mar 22, 2021

Create necessary directories

ba7c837

mandel-macaque approved these changes Mar 22, 2021

View reviewed changes

spouliot reviewed Mar 22, 2021

View reviewed changes

rolfbjarne approved these changes Mar 22, 2021

View reviewed changes

dalexsoto approved these changes Mar 22, 2021

View reviewed changes

chamons approved these changes Mar 22, 2021

View reviewed changes

jsquire mentioned this pull request Mar 22, 2021

[BUG]Azure SDK issues in Xamarin.iOS Azure/azure-sdk-for-net#19517

Closed

filipnavara mentioned this pull request Mar 22, 2021

System.Text.Json: Method not found System.Text.Encodings.Web.TextEncoder.FindFirstCharacterToEncodeUtf8 stil happens in NuGet 5.0.0 ans 5.0.1 dotnet/runtime#49940

Closed

Fix symlinks for packaging

d05bd13

filipnavara added 2 commits March 23, 2021 10:41

Add test case

a38eb74

Minor tweak to test case

19c0c3c

Fix cut & paste error

25308f2

filipnavara marked this pull request as ready for review March 23, 2021 19:51

rolfbjarne approved these changes Mar 24, 2021

View reviewed changes

rolfbjarne merged commit 85dd54d into dotnet:main Mar 24, 2021

vs-mobiletools-engineering-service2 mentioned this pull request Mar 24, 2021

[d16-9] Link FrameworkList.xml to a place where MSBuild SDK actually expects it #10953

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Mar 24, 2021

[xcode12.5] Link FrameworkList.xml to a place where MSBuild SDK actually expects it #10955

Merged

mandel-macaque mentioned this pull request Mar 25, 2021

The application throws 'MissingMethodException' or 'ExecutionEngineException' or refuses to be built at all with message 'Native linking failed' #10917

Closed

janusw mentioned this pull request Mar 29, 2021

Exception: Attempting to JIT toptensoftware/RichTextKit#32

Open

filipnavara mentioned this pull request Apr 15, 2021

Error MT5210: Linking fails for Release| ARM64 Builds; works fine for: "iPhone Simulator Release|x86_64", "iPhone Debug|ARM64", etc #10884

Closed

filipnavara mentioned this pull request Jun 8, 2021

Add special case for Xamarin assets to nuget precedence rules dotnet/designs#222

Closed

ericstj mentioned this pull request Jul 29, 2021

System.Text.Json: Method not found System.Text.Encodings.Web.TextEncoder.FindFirstCharacterToEncodeUtf8 happening in Xamarin.Android dotnet/runtime#56544

Closed

Link FrameworkList.xml to a place where MSBuild SDK actually expects it #10928

Link FrameworkList.xml to a place where MSBuild SDK actually expects it #10928

Conversation

filipnavara commented Mar 22, 2021 • edited Loading

rolfbjarne commented Mar 22, 2021

azure-pipelines bot commented Mar 22, 2021

vs-mobiletools-engineering-service2 commented Mar 22, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

rolfbjarne commented Mar 22, 2021

filipnavara commented Mar 22, 2021

spouliot left a comment

Choose a reason for hiding this comment

rolfbjarne commented Mar 22, 2021

azure-pipelines bot commented Mar 22, 2021

rolfbjarne commented Mar 22, 2021

filipnavara commented Mar 22, 2021 • edited Loading

chamons left a comment

Choose a reason for hiding this comment

mandel-macaque commented Mar 22, 2021

mandel-macaque commented Mar 22, 2021

filipnavara commented Mar 22, 2021

mandel-macaque commented Mar 22, 2021

filipnavara commented Mar 22, 2021

vs-mobiletools-engineering-service2 commented Mar 22, 2021

✅ Tests passed on Build. ✅

API diff

🎉 All 182 tests passed 🎉

filipnavara commented Mar 23, 2021 • edited Loading

rolfbjarne commented Mar 23, 2021

filipnavara commented Mar 23, 2021

rolfbjarne commented Mar 23, 2021

rolfbjarne commented Mar 23, 2021

filipnavara commented Mar 23, 2021

filipnavara commented Mar 23, 2021

dalexsoto commented Mar 23, 2021

filipnavara commented Mar 23, 2021

dalexsoto commented Mar 23, 2021

rolfbjarne commented Mar 24, 2021

dalexsoto commented Mar 24, 2021

dalexsoto commented Mar 24, 2021

vs-mobiletools-engineering-service2 commented Mar 24, 2021

vs-mobiletools-engineering-service2 commented Mar 24, 2021

vs-mobiletools-engineering-service2 commented Mar 24, 2021

rolfbjarne commented Mar 24, 2021

vs-mobiletools-engineering-service2 commented Mar 24, 2021

vs-mobiletools-engineering-service2 commented Mar 24, 2021

filipnavara commented Mar 22, 2021 •

edited

Loading

filipnavara commented Mar 22, 2021 •

edited

Loading

filipnavara commented Mar 23, 2021 •

edited

Loading