Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to submit XM apps to AppStore #6039

Closed
spouliot opened this issue May 10, 2019 · 1 comment
Closed

Make it easier to submit XM apps to AppStore #6039

spouliot opened this issue May 10, 2019 · 1 comment
Assignees
Labels
enhancement The issue or pull request is an enhancement macOS Issues affecting macOS
Milestone

Comments

@spouliot
Copy link
Contributor

QuickTime/QTKit is deprecated by Apple. Applications using it are rejected on the Mac App Store.

We cannot remove the API, without causing breaking changes, from Xamarin.Mac.dll but we can add an option to mmp to remove (as much as necessary of) QTKit bits to allow successful submissions.

Note: when using the managed linker (e.g. Link Framework SDKs only) then QTKit is removed (unless the application needs it). As such this enhancement is mostly for applications that can't (or do not want, e.g. extensibility) use the managed linker.

@spouliot spouliot added enhancement The issue or pull request is an enhancement macOS Issues affecting macOS labels May 10, 2019
@spouliot spouliot added this to the Future milestone May 10, 2019
@spouliot
Copy link
Contributor Author

from slack discussion

Rolf Kvinge [09:34]
I wonder if we should fine some solution to the QuickTime/QT prohibition

Sebastien Pouliot [09:34]
@Rolf yes

Rolf Kvinge [09:35]
maybe add --allow-prohibited-frameworks to mmp
or move those frameworks out of Xamarin.Mac.dll

Alex Soto [09:35]
Breaking change?
--allow-prohibited-frameworks sounds reasonable

Sebastien Pouliot [09:35]
not if done in mmp, I was thinking of --appstore-compliant
--allow-prohibited-frameworks requires the linker to always run

Rolf Kvinge [09:36]
not necessarily
we just don't link with the banned frameworks
or is Apple looking for strings in the executable?

Sebastien Pouliot [09:37]
hmm… not sure in this case - they do for other banned API
easy to try
let’s file that 🙂

@spouliot spouliot self-assigned this May 22, 2019
spouliot added a commit to spouliot/xamarin-macios that referenced this issue May 23, 2019
…ore. Fix dotnet#6039

So far this only applies to `QTKit`...

XM will now, by default, avoid natively link with QTKit unless it's
instructed to so explicitly using `--link-prohibited-frameworks`

ref: dotnet#6039
@ghost ghost locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement The issue or pull request is an enhancement macOS Issues affecting macOS
Projects
None yet
Development

No branches or pull requests

1 participant